bug(diff): unified layout skips diff lifecycle User events

[ThomasK33]

Summary

diff_opts.layout = "unified" appears to skip the ClaudeCodeDiffOpened and ClaudeCodeDiffClosed User autocmds that are documented for proposed-edit diffs.

Evidence

• lua/claudecode/diff.lua dispatches layout == "unified" to claudecode.diff_inline.setup_inline_diff(...) before the native diff path reaches the common ClaudeCodeDiffOpened event emission.
• lua/claudecode/diff_inline.lua opens the unified diff split, renders the scratch buffer, and registers diff state, but does not emit ClaudeCodeDiffOpened.
• lua/claudecode/diff.lua also returns early from _cleanup_diff_state for diff_data.layout == "unified" after calling inline.cleanup_inline_diff(...), before the common ClaudeCodeDiffClosed event emission.
• lua/claudecode/diff_inline.lua cleanup does not emit ClaudeCodeDiffClosed either.

Expected behavior

All diff layouts that open a proposed-edit review UI should fire the same lifecycle events, matching the README's Diff Lifecycle Events section:

• ClaudeCodeDiffOpened when the unified diff opens
• ClaudeCodeDiffClosed when the unified diff is accepted/rejected/cleaned up

Impact

User configs that rely on these events for terminal resizing, statusline updates, or other review-lifecycle behavior work for native vertical/horizontal diffs but not for the unified layout.

Validation performed

• Searched existing open and closed issues for ClaudeCodeDiffOpened, ClaudeCodeDiffClosed, unified, and autocmd; only diff: reconsider layout = "inline" naming before v0.4.0 (reserve "inline" for a true in-place overlay) #293/diff: add a true in-place "inline" overlay (virtual text) as the future layout = "inline" #294 mention this gap, and neither is a dedicated bug tracker for the current unified layout behavior.
• Ran mise exec -- busted -v tests/unit/diff_inline_spec.lua tests/unit/diff_auto_resize_events_spec.lua — 39 successes / 0 failures.
• Ran mise run check — 0 warnings / 0 errors.

Found while triaging #294.

[ThomasK33]

Note

This triage report is AI-generated using Mux

Classification

Confirmed bug in unified diff lifecycle event parity.

Findings

• The documented lifecycle events are present for the native diff path, but the unified layout dispatches to diff_inline.setup_inline_diff(...) before the common ClaudeCodeDiffOpened emission in diff.lua.
• During cleanup, diff.lua returns early for diff_data.layout == "unified" after diff_inline.cleanup_inline_diff(...), before the common ClaudeCodeDiffClosed emission.
• diff_inline.lua registers and cleans up unified diff state, but it does not emit either lifecycle User autocmd.

Reproduction / control

Using the repo's Lua test harness:

• mise run setup
• One-off mise exec -- luajit harness with diff_opts.layout = "unified" intercepting vim.api.nvim_exec_autocmds: setup_ok=true, close_ok=true, event_count=0, opened_event=false, closed_event=false.
• The same harness with diff_opts.layout = "vertical": event_count=2, opened_event=true, closed_event=true.

Existing validation

• mise exec -- busted -v tests/unit/diff_inline_spec.lua tests/unit/diff_auto_resize_events_spec.lua → 39 successes / 0 failures / 0 errors.
• mise run check → 0 warnings / 0 errors.
• Duplicate search for lifecycle/unified/autocmd terms found this issue plus related layout discussions diff: add a true in-place "inline" overlay (virtual text) as the future layout = "inline" #294 and diff: reconsider layout = "inline" naming before v0.4.0 (reserve "inline" for a true in-place overlay) #293; those are not dedicated trackers for this current event-parity defect.

Recommendation

Keep this open as a bug. A focused fix should make the unified diff path emit ClaudeCodeDiffOpened after unified state/window registration and emit ClaudeCodeDiffClosed during unified cleanup, preserving the documented payload shape as closely as possible to the native path. Add regression coverage for unified open/close lifecycle events; existing event tests cover native open/cleanup but not unified lifecycle parity.