fix: add tests for Trezor Zcash API error handling and improve zero balance parsing

Author: galvanizze

blockapi/test/v2/api/test_trezor_zec.py

@@ -5,6 +5,7 @@
 from blockapi.test.v2.api.conftest import read_file
 from blockapi.test.v2.test_data import zec_test_address
 from blockapi.v2.api import TrezorZcashApi
+from blockapi.v2.base import ApiException
 from blockapi.v2.models import FetchResult
 
 
@@ -38,6 +39,63 @@ def test_parse_only():
     assert result.data[0].balance == Decimal('12.345')
 
 
+def test_parse_zero_balance():
+    api = TrezorZcashApi()
+    fetch_result = FetchResult(data=dict(balance='0'))
+    result = api.parse_balances(fetch_result)
+    assert result.data is None
+
+
+def test_fetch_invalid_address(requests_mock):
+    invalid_address = 'not-a-valid-zec-address'
+    requests_mock.get(
+        f'https://blockbook.zec.zelcore.io/api/v2/address/{invalid_address}',
+        status_code=400,
+        reason='Bad Request',
+    )
+
+    api = TrezorZcashApi()
+    result = api.fetch_balances(invalid_address)
+    assert result.errors == ['Bad Request']
+
+
+def test_get_balance_invalid_address_should_raise(requests_mock):
+    invalid_address = 'not-a-valid-zec-address'
+    requests_mock.get(
+        f'https://blockbook.zec.zelcore.io/api/v2/address/{invalid_address}',
+        status_code=400,
+        reason='Bad Request',
+    )
+
+    api = TrezorZcashApi()
+    with pytest.raises(ApiException, match='Bad Request'):
+        api.get_balance(invalid_address)
+
+
+def test_fetch_error_response(requests_mock):
+    requests_mock.get(
+        f'https://blockbook.zec.zelcore.io/api/v2/address/{zec_test_address}',
+        status_code=500,
+        reason='Internal Server Error',
+    )
+
+    api = TrezorZcashApi()
+    result = api.fetch_balances(zec_test_address)
+    assert result.errors == ['Internal Server Error']
+
+
+def test_get_balance_should_raise(requests_mock):
+    requests_mock.get(
+        f'https://blockbook.zec.zelcore.io/api/v2/address/{zec_test_address}',
+        status_code=500,
+        reason='Internal Server Error',
+    )
+
+    api = TrezorZcashApi()
+    with pytest.raises(ApiException, match='Internal Server Error'):
+        api.get_balance(zec_test_address)
+
+
 @pytest.fixture
 def trezor_zec_balance_response():
     return read_file('data/trezor_zec_balance_response.json')

blockapi/v2/api/trezor.py

@@ -45,9 +45,13 @@ def parse_balances(self, fetch_result: FetchResult) -> ParseResult:
         if not fetch_result.data:
             return ParseResult()
 
+        balance_raw = fetch_result.data.get('balance')
+        if not balance_raw or balance_raw == '0':
+            return ParseResult()
+
         balances = [
             BalanceItem.from_api(
-                balance_raw=fetch_result.data.get('balance'),
+                balance_raw=balance_raw,
                 coin=self.coin,
                 asset_type=AssetType.AVAILABLE,
                 raw=fetch_result.data,