CCK upgrade paths

[luke-hill]

🤔 What's the problem you've observed?

We're very far behind of CCK conformance

✨ Do you have a proposal for making it better?

Upgrade to CCK v22 in the v11 of cucumber-ruby. Then do the following upgrade paths

22->24

• Likely to involve some breaking changes in namespacing of CCK proper
• Will add in a few more samples - including a test run exception

24->26

• Should be a fairly lightweight upgrade
• Changes structure of some internals (So refactoring might be needed)

26->29

• Internal structure changes again
• Lots of new status style samples

📚 Any additional context?

By the time these 3 upgrade paths have been done, we may have need for another set of upgrades

[luke-hill]

Update. Children bugfix was made too early for CCK conformance. All these scenarios will need to be guarded against until CCK v29

[olleolleolle]

👋 Is it so that adding :timestamp in #1809 made some tests trip?

bundle exec rspec --tag cck --pattern compatibility/cck_spec.rb -f d

E.g.

  6) CCK 'examples-tables-attachment' example generates valid message structure
     Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { |failure, _opts| raise failure }
       There were comparison errors: ["Detected extra keys in message Cucumber::Messages::Attachment: [:timestamp]", "Detected extra keys in message Cucumber::Messages::Attachment: [:timestamp]"]
     Shared Example Group: "cucumber compatibility kit" called from ./compatibility/cck_spec.rb:18
     # ./compatibility/support/shared_examples.rb:28:in `block (2 levels) in <top (required)>'

[luke-hill]

Possibly yes. I'm analysing and slowly fixing up things. But that was needed to fix other things.

Because I'm quite far behind on CCK conformance there's just a lot to do

The work is being monitored in #1806 and interim PR's are being made into main and then merged back into that branch as/when required.

Think of #1806 as the "closest" source of truth

[luke-hill]

Update @olleolleolle CCK v22 had 3 issues. 2 of which require a solution porting over from cucumber-JS (Failure execution). One of which is something we're all (major flavours), ahead of the curve of.

[luke-hill]

CCKv22 migration complete (With a few caveats) ✔️
CCKv22 fixes currently in PR 🚶
CCKv22->v24 PR made good strides - One potential slipping point which only affects a couple of conformancies (Suggestion snippets)