CM-60184-Review feedback

Author: mateusz-sterczewski

cycode/cli/apps/scan/code_scanner.py

@@ -329,7 +329,7 @@ def _perform_scan(
         # it does not support commit range scans; should_use_sync_flow handles it
         return _perform_scan_sync(cycode_client, zipped_documents, scan_type, scan_parameters, is_git_diff)
 
-    if scan_type == consts.SAST_SCAN_TYPE:
+    if should_use_presigned_upload(scan_type):
         return _perform_scan_v4_async(
             cycode_client, zipped_documents, scan_type, scan_parameters, is_git_diff, is_commit_range
         )

cycode/cli/apps/scan/commit_range_scanner.py

@@ -44,6 +44,7 @@
     generate_unique_scan_id,
     is_cycodeignore_allowed_by_scan_config,
     set_issue_detected_by_scan_results,
+    should_use_presigned_upload,
 )
 from cycode.cyclient.models import ZippedFileScanResult
 from cycode.logger import get_logger
@@ -150,7 +151,7 @@ def _scan_commit_range_documents(
             # for SAST it is files with diff between from_commit and to_commit
             to_commit_zipped_documents = zip_documents(scan_type, to_documents_to_scan)
 
-            if scan_type == consts.SAST_SCAN_TYPE:
+            if should_use_presigned_upload(scan_type):
                 scan_result = _perform_commit_range_scan_v4_async(
                     cycode_client,
                     from_commit_zipped_documents,

cycode/cyclient/scan_client.py

@@ -138,6 +138,7 @@ def get_upload_link(self, scan_type: str) -> models.UploadLinkResponse:
     def upload_to_presigned_post(self, url: str, fields: dict[str, str], zip_file: 'InMemoryZip') -> None:
         multipart = {key: (None, value) for key, value in fields.items()}
         multipart['file'] = (None, zip_file.read())
+        # We are not using Cycode client, as we are calling aws S3.
         response = requests.post(url, files=multipart, timeout=self.scan_cycode_client.timeout)
         response.raise_for_status()