Skip to content

Bug: follow-up fixes for workspace inline path links after #239 #262

@DerrickBarra

Description

@DerrickBarra

Summary

After merging #239, a few renderer/linkification edge cases still need a focused follow-up bugfix pass for workspace path links in markdown/chat.

This is not a re-open of the original feature lane from #237 / #239. It is still the existing post-merge workspace-inline-reference follow-up lane discovered while validating the merged behavior on a downstream integration branch.

In Plain English

This issue is about making chat/workspace file links behave the way users naturally expect.

The original feature already made /workspace/... paths clickable, and this follow-up now also treats bare workspace/... as an intentionally supported shorthand for that same canonical workspace target. At the same time, malformed near-misses should still stay plain text — for example bare workspace/ or interior-token forms like path=workspace/foo.md should not become links.

In short: fewer false negatives, fewer false positives, and a clearer contract for accepted workspace inline references.

Scope

  • linkify embedded /workspace/... path slices inside surrounding text
  • narrow inline path token typing so the matcher does not overreach
  • handle wrapped / punctuation-adjacent workspace inline links correctly
  • treat bare workspace/... as intentional shorthand for canonical /workspace/... within the same workspace-inline-reference lane
  • keep malformed negatives plain while tightening workspace-rooted matching and resolve-path guardrails so only intended workspace-style paths become actionable

Provenance

Clean source branch: bugfix/workspace-inline-reference-slice

Commits on that branch:

  • 36cca92fix(markdown): linkify embedded workspace path slices
  • d3d3a64fix(markdown): narrow inline path match typing
  • a04876eFix wrapped workspace inline path links
  • 6cf2616Tighten workspace-rooted inline path matching
  • d0d4b40fix(markdown): address PR review follow-ups
  • bea1fa1Support bare workspace inline references
  • 349dc5cClarify workspace shorthand inline path contract

Downstream validation already happened via cherry-picks on a local workhorse integration branch:

  • 4e3c8fb <- 36cca92
  • 2b064f0 <- d3d3a64
  • 719db38 <- a04876e
  • 5435706 <- 6cf2616
  • a8faf29 <- 349dc5c

Related prior art

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions