Pulling in old vulnerable version of maven-core

[johanblumenberg]

Precondition

• I checked the issues list for existing open or closed reports of the same problem.

Describe the bug

dependency-check-maven contains a compile dependency to org.apache.maven.shared:maven-artifact-transfer:0.13.1 which contains a compile dependency to org.apache.maven:maven-core.
dependency-check-maven contains a provided dependency to org.apache.maven:maven-core:3.6.3.
This means that dependency-check-maven will pull in org.apache.maven:maven-core:3.6.3 as a compile dependency.

org.apache.maven:maven-core:3.6.3 contains the critical vulnerability CVE-2021-26291: https://mvnrepository.com/artifact/org.apache.maven/maven-core/3.6.3

The recommendation is to have a provided dependency to maven-core, not compile, and the org.apache.maven.shared:maven-artifact-transfer artifact is deprecated.

Version of dependency-check used
The problem occurs using version 12.1.0 of the maven plugin.

Log file
N/A

To Reproduce
Steps to reproduce the behavior:

1. Create a simple project containing dependency-check-maven, like this: https://gist.github.com/johanblumenberg/72d74aa8520292e1fb220a06de1490af
2. Run mvn verify
3. Open target/dependency-check-report.html and check the critical items reported.

Expected behavior

No critical vulnerabilities coming from the dependency-check-maven plugin itself.

Additional context

N/A

[aikebah]

It does not drag in the library at compile scope, but at provided scope as can be observed when running mvn dependency:tree -Dincludes=org.apache.maven on the maven plugin:

1387 [main] [INFO] org.apache.maven.cli.event.ExecutionEventLogger - --- dependency:3.8.1:tree (default-cli) @ dependency-check-maven ---
1690 [main] [INFO] org.apache.maven.plugins.dependency.tree.TreeMojo - org.owasp:dependency-check-maven:maven-plugin:12.1.1-SNAPSHOT
1690 [main] [INFO] org.apache.maven.plugins.dependency.tree.TreeMojo - +- org.apache.maven:maven-plugin-api:jar:3.6.3:provided
1690 [main] [INFO] org.apache.maven.plugins.dependency.tree.TreeMojo - +- org.apache.maven:maven-settings:jar:3.6.3:provided
1690 [main] [INFO] org.apache.maven.plugins.dependency.tree.TreeMojo - +- org.apache.maven:maven-core:jar:3.6.3:provided
1690 [main] [INFO] org.apache.maven.plugins.dependency.tree.TreeMojo - |  +- org.apache.maven:maven-builder-support:jar:3.6.3:provided
1690 [main] [INFO] org.apache.maven.plugins.dependency.tree.TreeMojo - |  +- org.apache.maven:maven-repository-metadata:jar:3.6.3:provided
1690 [main] [INFO] org.apache.maven.plugins.dependency.tree.TreeMojo - |  +- org.apache.maven:maven-model-builder:jar:3.6.3:provided
1690 [main] [INFO] org.apache.maven.plugins.dependency.tree.TreeMojo - |  \- org.apache.maven:maven-resolver-provider:jar:3.6.3:provided
1690 [main] [INFO] org.apache.maven.plugins.dependency.tree.TreeMojo - +- org.apache.maven:maven-settings-builder:jar:3.6.3:provided
1690 [main] [INFO] org.apache.maven.plugins.dependency.tree.TreeMojo - +- org.apache.maven:maven-model:jar:3.6.3:provided
1690 [main] [INFO] org.apache.maven.plugins.dependency.tree.TreeMojo - \- org.apache.maven:maven-artifact:jar:3.6.3:provided

The maven dependencies are dependency-managed at version 3.6.3 in order to avoid any risk of using post-3.6.3 new maven API, thereby breaking our claim of Maven 3.6.3+ compatibility. The plugin will (because of this provided scope) use the maven libraries of the maven install that runs the plugin.

[aikebah]

What your project is surfacing is a potential bug in the plugin dependencies scope evaluation, or a scope override for maven-core by another part of your project.

[bjansen]

@chadlwilson may I ask why you closed the issue? Its title might be badly worded, I don't believe @johanblumenberg wants you to upgrade the version of maven-core you use. They are just observing that on an empty pom with no plugins other than dependency-check, and with a Maven runtime in version 3.9.9, dependency-check flags itself as vulnerable because even though maven-core has a provided scope, version 3.6.3 is analyzed and appears in the HTML output file:

[chadlwilson]

Ok, was probably a bit hasty. Perhaps misinterpreted what aikebah and OP were saying. OP didn't respond.

FWIW this project gets vast amounts of noise and I don't think anyone has the time to be second guessing over multiple interactions. Having hundreds of open issues doesn't get any of them resolved 😓

[johanblumenberg]

Thank you for reopening this issue.

Indeed, the dependency to maven-core is supposed to have the provided scope, since the pom in the dependency-check plugin has set it to provided.

But when executing the plugin, it is clearly downloading maven-core:3.6.3.

Here I am removing maven-core and plexus-utils from the local repository to see what is being downloaded. I am comparing with plexus-core since that is a compile dependency, and should for sure be downloaded before the plugin executes.

$ rm -rf ~/.m2/repository/org/apache/maven/maven-core
$ rm -rf ~/.m2/repository/org/codehaus/plexus/plexus-utils/

$ mvn verify                                               
[INFO] Scanning for projects...
[INFO] 
[INFO] -----------------------< com.test:root-project >------------------------
[INFO] Building root-project 0.0.1-SNAPSHOT
[INFO] --------------------------------[ pom ]---------------------------------
[INFO] 
[INFO] --- dependency-check-maven:12.1.0:aggregate (default) @ root-project ---
Downloading from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-utils/4.0.2/plexus-utils-4.0.2.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-utils/4.0.2/plexus-utils-4.0.2.pom (13 kB at 78 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/maven-core/3.6.3/maven-core-3.6.3.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/maven-core/3.6.3/maven-core-3.6.3.pom (8.8 kB at 630 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-utils/4.0.2/plexus-utils-4.0.2.jar
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/maven-core/3.6.3/maven-core-3.6.3.jar
Downloaded from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-utils/4.0.2/plexus-utils-4.0.2.jar (193 kB at 5.1 MB/s)
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/maven-core/3.6.3/maven-core-3.6.3.jar (633 kB at 8.7 MB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-utils/4.0.1/plexus-utils-4.0.1.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-utils/4.0.1/plexus-utils-4.0.1.pom (7.8 kB at 373 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-utils/4.0.1/plexus-utils-4.0.1.jar
Downloaded from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-utils/4.0.1/plexus-utils-4.0.1.jar (193 kB at 10 MB/s)
[INFO] Checking for updates
[INFO] Skipping the NVD API Update as it was completed within the last 240 minutes
[INFO] Skipping Known Exploited Vulnerabilities update check since last check was within 24 hours.
[INFO] Check for updates complete (169 ms)
[INFO] 

However, it looks like maven-core:3.6.3 is never being executed. The plugin has no problems executing, but when analyzing maven-core:3.6.3 it cannot open the jar file.

$ echo "" > ~/.m2/repository/org/apache/maven/maven-core/3.6.3/maven-core-3.6.3.jar

$ mvn verify                                               
[INFO] Scanning for projects...
[INFO] 
[INFO] -----------------------< com.test:root-project >------------------------
[INFO] Building root-project 0.0.1-SNAPSHOT
[INFO] --------------------------------[ pom ]---------------------------------
[INFO] 
[INFO] --- dependency-check-maven:12.1.0:aggregate (default) @ root-project ---
[INFO] Checking for updates
[INFO] Skipping the NVD API Update as it was completed within the last 240 minutes
[INFO] Skipping Known Exploited Vulnerabilities update check since last check was within 24 hours.
[INFO] Check for updates complete (189 ms)
[INFO] 

Dependency-Check is an open source tool performing a best effort analysis of 3rd party dependencies; false positives and false negatives may exist in the analysis performed by the tool. Use of the tool and the reporting provided constitutes acceptance for use in an AS IS condition, and there are NO warranties, implied or otherwise, with regard to the analysis or its use. Any use of the tool and the reporting provided is at the user's risk. In no event shall the copyright holder or OWASP be held liable for any damages whatsoever arising out of or in connection with the use of this tool, the analysis performed, or the resulting report.


   About ODC: https://jeremylong.github.io/DependencyCheck/general/internals.html
   False Positives: https://jeremylong.github.io/DependencyCheck/general/suppression.html

💖 Sponsor: https://github.com/sponsors/jeremylong


[INFO] Analysis Started
[INFO] Finished Archive Analyzer (0 seconds)
[INFO] Finished File Name Analyzer (0 seconds)
[WARNING] Unable to open jar file 'maven-core-3.6.3.jar'.

[jeremylong]

It cannot open the jar file in your last example because you overwrote it with an empty string:

echo "" > ~/.m2/repository/org/apache/maven/maven-core/3.6.3/maven-core-3.6.3.jar

[jeremylong]

I decided to ask ChatGPT o4 and received a really interesting explanation:

---

Yes, this behavior is subtle but understandable when you dig into how Maven resolves plugin dependencies and interprets the provided scope in the context of plugins, which differs from how it works for application dependencies.

💡 TL;DR:

Even though you've declared maven-core as provided, Maven resolves the plugin's dependencies based on what's declared in its pom.xml, not based on the runtime Maven version—because plugin dependencies are resolved from the plugin's POM metadata, not the Maven runtime classpath.

🧩 Explanation

1. Scope provided for maven-core in a plugin POM:

   The provided scope means: "this dependency is needed to compile the plugin but will be provided at runtime". In theory, this tells Maven not to package or resolve it during plugin execution, because it's assumed to be present in the environment (e.g., the running Maven instance).

2. But during dependency:resolve-plugins:

   The dependency:resolve-plugins goal analyzes the plugin’s POM and resolves all dependencies (even provided ones) to determine what would be required if the plugin were run in isolation.

   Thus, even provided dependencies are listed—because the plugin POM explicitly names maven-core with version 3.6.1.

3. Why 3.6.1 shows up:

   Maven doesn't automatically align the provided dependency version with the version of Maven running the build.

   If your plugin declares maven-core version 3.6.1, even with scope provided, Maven sees that version as part of the plugin metadata and includes it when listing dependencies via dependency:resolve-plugins.

4. At runtime (actual plugin execution):

   The Maven runtime provides its own version of maven-core, which overrides any provided dependency from the plugin. So even though resolve-plugins shows 3.6.1, at actual execution, it uses the Maven runtime’s maven-core.

✅ How to avoid confusion

If your goal is to:

• Avoid locking the plugin to a specific Maven version,
• Signal that the plugin should work with whichever Maven version is executing the build,

Then you have a few options:

1. Omit maven-core entirely
   If you only use Maven API classes that are guaranteed to exist in the runtime, you don’t need to declare maven-core at all. The Maven runtime will always provide it.

2. Use Maven's provided BOM
   If you must compile against Maven core APIs, you can optionally use a Maven BOM or property to match the runtime Maven version used in your build environment (but this only helps within your own builds, not plugin consumers).

3. Document compatibility, don’t lock versions
   Simply omit the or at least avoid declaring an old one like 3.6.1—otherwise, it gives the false impression that your plugin is pinned to that version.

🔎 Summary

• Maven resolves plugin dependencies strictly based on the plugin's POM.
• scope=provided doesn't stop the dependency from showing up in tools like dependency:resolve-plugins.
• Actual plugin execution uses the Maven runtime’s maven-core, regardless of what’s declared in the plugin POM.
• Declaring a specific version like 3.6.1 gives misleading signals unless you’re actively targeting that version.

[chadlwilson]

As to the "root cause" here, when scanning Maven plugins, I don't think the current logic has the ability to apply the normal skipProvidedScope exclusions (or other exclusions) that can be applied to regular dependencies?

DependencyCheck/maven/src/main/java/org/owasp/dependencycheck/maven/BaseDependencyCheckMojo.java

Lines 1398 to 1436 in 91ffcf6

	protected ExceptionCollection scanPlugins(MavenProject project, Engine engine, ExceptionCollection exCollection) {
	ExceptionCollection exCol = exCollection;
	final Set<Artifact> plugins = new HashSet<>();
	final Set<Artifact> buildPlugins = getProject().getPluginArtifacts();
	final Set<Artifact> reportPlugins = getProject().getReportArtifacts();
	final Set<Artifact> extensions = getProject().getExtensionArtifacts();
	plugins.addAll(buildPlugins);
	plugins.addAll(reportPlugins);
	plugins.addAll(extensions);
	final ProjectBuildingRequest buildingRequest = newResolveArtifactProjectBuildingRequest(project, project.getPluginArtifactRepositories());
	for (Artifact plugin : plugins) {
	try {
	final Artifact resolved = artifactResolver.resolveArtifact(buildingRequest, plugin).getArtifact();
	exCol = addPluginToDependencies(project, engine, resolved, "pom.xml (plugins)", exCol);
	final DefaultDependableCoordinate pluginCoordinate = new DefaultDependableCoordinate();
	pluginCoordinate.setGroupId(resolved.getGroupId());
	pluginCoordinate.setArtifactId(resolved.getArtifactId());
	pluginCoordinate.setVersion(resolved.getVersion());
	final String parent = buildReference(resolved.getGroupId(), resolved.getArtifactId(), resolved.getVersion());
	for (Artifact artifact : resolveArtifactDependencies(pluginCoordinate, project)) {
	exCol = addPluginToDependencies(project, engine, artifact, parent, exCol);
	}
	} catch (ArtifactResolverException ex) {
	throw new RuntimeException(ex);
	} catch (IllegalArgumentException ex) {
	throw new RuntimeException(ex);
	} catch (DependencyResolverException ex) {
	throw new RuntimeException(ex);
	}
	}
	return null;
	}

[jeremylong]

After doing some more testing - I'm positive ChatGPT's answer is correct. In a sample project I ran mvn dependency:resolve-plugins:

[INFO] The following plugins have been resolved:
[INFO]    org.owasp:dependency-check-maven:maven-plugin:12.1.2-SNAPSHOT:runtime
[INFO]       org.owasp:dependency-check-maven:jar:12.1.2-SNAPSHOT
[INFO]       org.owasp:dependency-check-core:jar:12.1.2-SNAPSHOT
...
[INFO]       org.apache.maven.shared:maven-artifact-transfer:jar:0.13.1
[INFO]       org.apache.maven:maven-core:jar:3.6.3
[INFO]       org.apache.maven:maven-model:jar:3.6.3
...
[INFO]    org.apache.maven.plugins:maven-site-plugin:maven-plugin:3.12.1:runtime
...
[INFO]       org.apache.maven:maven-artifact:jar:3.2.5
[INFO]       org.apache.maven:maven-core:jar:3.2.5

You'll see that when we resolve the plugin's dependencies the tree has two different versions of maven-core listed. Unlike what happens with the standard dependencies where it would select one.

[jeremylong]

@chadlwilson we can get the scope by calling getScope() on the artifacts retrieved. Maybe we can denote in the report the provided plugin dependencies?

Maybe the best option would be to add a skipProvidedPluginDependencies option that defaults to true.