Is libvirt.DomainOpenConsole can do input

[tuna2134]

func (l *Libvirt) DomainOpenConsole(Dom Domain, DevName OptString, inStream io.Writer, Flags uint32) (err error)

I read docs and it looks like only do output

[trapgate]

The stream in this function should be bidirectional, however, the code generator doesn't currently support bidirectional streams and needs to be updated.

[trapgate]

Another problem: the code generator uses annotations from remote_protocol.x in the libvirt sources to determine the directionality of streams. The virDomainOpenConsole function has no entry in that file, so no annotations.

[tuna2134]

Oh, I see

[tuna2134]

so, is it very hard to do that?

[trapgate]

You can try patching the generated code first - you want that third parameter to be stream io.ReadWriter. You can then experiment with the patched code and see if it works. If so, the next step is to get the generator to produce that working code. You can look at AddProcEnumVal() in generate.go. We don't have an annotation from the comments in libvirt's remote_protocol.x to go by for this function, but possibly in the absence of an annotation we can default to creating a bidirectional stream rather than a read stream. You'd then want to re-run the generator and look at the diffs between the old and new generated code, and verify that the new generated code is correct.

[tuna2134]

at this?
https://github.com/libvirt/libvirt/blob/c573d08ccf5c73baf799adcd20c7a4faa76d6f1c/src/remote/remote_protocol.x#L5454

[tuna2134]

Well, it looks like forget to add writestream

[tuna2134]

I don't know if i did this true.
https://github.com/tuna2134/go-libvirt/blob/e8a984b698432e17b9c30617feec45c5813df219/internal/lvgen/generate.go#L619