cost-alert.ts: missing costResetAt clipping and limitTotalUsd/limitDailyUsd checks

[sususu98]

Summary

src/lib/notification/tasks/cost-alert.ts has two gaps that cause incorrect alert behavior after quota resets and missing alerts for total/daily limits.

Problem 1: costResetAt not considered

The cost alert system queries raw time ranges without clipping by costResetAt:

// current (cost-alert.ts)
const cost5h = await sumKeyCostInTimeRange(keyData.id, range5h.startTime, range5h.endTime);

In contrast, rate-limit-guard.ts and all quota display paths correctly clip the start time:

// rate-limit-guard.ts (correct)
const keyCostResetAt = resolveKeyCostResetAt(key.costResetAt ?? null, user.costResetAt ?? null);
const clipStart = (start: Date) => costResetAt > start ? costResetAt : start;

Impact: After an admin resets a user's or key's quota, the rate limiter correctly counts from zero, but the alert system still fires based on pre-reset usage. Users receive false "approaching quota" notifications.

This affects both user-level costResetAt (existing) and key-level costResetAt (new in feat/key-cost-reset).

Problem 2: limitTotalUsd and limitDailyUsd not checked

The alert query only selects three limit types:

const keysWithLimits = await db.select({
  limit5h: keys.limit5hUsd,
  limitWeek: keys.limitWeeklyUsd,
  limitMonth: keys.limitMonthlyUsd,
  // limitTotalUsd - missing
  // limitDailyUsd - missing
}).from(keys).where(
  sql`${keys.limit5hUsd} > 0 OR ${keys.limitWeeklyUsd} > 0 OR ${keys.limitMonthlyUsd} > 0`
);

Impact: Keys with limitTotalUsd or limitDailyUsd set will never receive approaching-quota alerts for those periods.

Suggested Fix

1. Join with users table to get user.costResetAt, and select key.costResetAt
2. Use resolveKeyCostResetAt() to compute effective reset time per key
3. Clip all time range starts with clipStart() before querying costs
4. Add limitTotalUsd check using sumKeyTotalCost(keyHash, Infinity, resolvedResetAt)
5. Add limitDailyUsd check using sumKeyCostInTimeRange with daily time range (respecting dailyResetTime and dailyResetMode)

Affected Files

• src/lib/notification/tasks/cost-alert.ts

[coderabbitai]

🔗 Related PRs

#531 - fix: 当用户限额未设置时，key 限额不生效 [merged]
#668 - feat: timezone consistency & rate-limit lease-based quota [merged]
#674 - fix(rate-limit): unify lease mechanism for all periodic cost limits [merged]
#853 - feat: soft user limit reset via costResetAt [merged]
#890 - feat: add costResetAt for soft user limit reset without deleting data [merged]

---

📝 Issue Planner

_{Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.}

• Create Plan

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!

[github-actions]

Thank you for this detailed bug report. Based on my analysis of the codebase, I can confirm both issues you have identified.

Analysis

Problem 1: Missing costResetAt clipping

In src/lib/notification/tasks/cost-alert.ts, the cost queries do not account for costResetAt. For example, at lines 91-95:

const cost5h = await sumKeyCostInTimeRange(
  keyData.id,
  range5h.startTime,
  range5h.endTime
);

In contrast, src/app/v1/_lib/proxy/rate-limit-guard.ts correctly uses costResetAt via checkCostLimitsWithLease (lines 228-234, 265-271, etc.) to ensure cost calculations respect the reset time.

Impact: After a quota reset, users may receive false "approaching quota" notifications based on pre-reset usage.

Problem 2: Missing limitTotalUsd and limitDailyUsd checks

In src/lib/notification/tasks/cost-alert.ts at lines 62-76, the query only selects:

limit5h: keys.limit5hUsd,
limitWeek: keys.limitWeeklyUsd,
limitMonth: keys.limitMonthlyUsd,

The limitTotalUsd and limitDailyUsd fields are not queried or checked.

Impact: Keys with only limitTotalUsd or limitDailyUsd set will never receive approaching-quota alerts for those periods.

Suggested Fix Approach

1. Join with the users table to get user.costResetAt and select key.costResetAt
2. Use a pattern similar to rate-limit-guard.ts to clip time ranges based on costResetAt before querying costs
3. Add limitTotalUsd and limitDailyUsd to the query and implement corresponding alert checks

---

Automated response from Claude AI

[github-actions]

This issue has been automatically marked as stale because it has not had any activity in the last 30 days.

If this issue is still relevant:

• Please comment to keep it open
• Add any new information that might help resolve it

This issue will be automatically closed in 14 days if there is no further activity.

[github-actions]

This issue has been automatically marked as stale because it has not had any activity in the last 30 days.

If this issue is still relevant:

• Please comment to keep it open
• Add any new information that might help resolve it

This issue will be automatically closed in 14 days if there is no further activity.