From d3635fd5a9560eee95081249c98d71e8b7a284b1 Mon Sep 17 00:00:00 2001 From: kovan Date: Fri, 13 Feb 2026 04:44:58 +0100 Subject: [PATCH] fix(keybinds): remove :major-modes from localleader definitions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `define-localleader-key!` unconditionally set `:major-modes t`, which makes general.el infer mode names from keymap names and use `which-key-add-major-mode-key-based-replacements`. This only works for major mode keymaps — minor mode keymaps (like `cider-mode-map`) get their which-key descriptions silently dropped. Without `:major-modes`, general.el uses `which-key-add-keymap-based-replacements` instead, which works for all keymaps. The `:keymaps` property (always provided by `map!`) already scopes bindings to the correct keymap. Fix: #8539 Co-authored-by: Claude Opus 4.6 --- lisp/doom-keybinds.el | 2 -- 1 file changed, 2 deletions(-) diff --git a/lisp/doom-keybinds.el b/lisp/doom-keybinds.el index 1269bd54cfe..6187b2c3bf9 100644 --- a/lisp/doom-keybinds.el +++ b/lisp/doom-keybinds.el @@ -199,12 +199,10 @@ localleader prefix." ;; emacs state) `(general-define-key :states '(normal visual motion emacs insert) - :major-modes t :prefix doom-localleader-key :non-normal-prefix doom-localleader-alt-key ,@args) `(general-define-key - :major-modes t :prefix doom-localleader-alt-key ,@args)))