[EntityAjaxType] Not clear list if not valid but synchronized

Author: hlecorche

src/Form/Type/EntityAjaxType.php

@@ -63,6 +63,7 @@ public function buildView(FormView $view, FormInterface $form, array $options):
     {
         $view->vars['url'] = $this->router->generate($options['route_name'], $options['route_parameters']);
         $view->vars['multiple'] = $options['multiple'];
+        $view->vars['list_is_synchronized'] = $form->isSynchronized();
 
         if ($options['multiple']) {
             $view->vars['full_name'] .= '[]';

templates/Form/entity_ajax.html.twig

@@ -10,8 +10,8 @@
     {% endif %}
 
     <select {{ block('widget_attributes') }}>
-        {# If null (invalid) or if invalid : Not display list because several labels are missing #}
-        {% if value is not null and valid %}
+        {# If null (not valid) or if not synchronized : Not display list because several labels are missing #}
+        {% if value is not null and list_is_synchronized %}
             {% for id, label in value %}
                 <option value="{{ id }}" selected="selected">{{ label }}</option>
             {% endfor %}

tests/Form/Type/EntityAjaxTypeTest.php

@@ -22,6 +22,7 @@
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Symfony\Component\Form\FormFactoryInterface;
 use Symfony\Component\OptionsResolver\Exception\MissingOptionsException;
+use Symfony\Component\Validator\Constraints\Blank;
 
 class EntityAjaxTypeTest extends KernelTestCase
 {
@@ -82,6 +83,7 @@ public function testView(bool $multiple, $modelData, $dataBuilderName, $expected
         $this->assertSame($expectedViewValue, $view->vars['value']);
         $this->assertSame('/fake', $view->vars['url']);
         $this->assertSame($multiple, $view->vars['multiple']);
+        $this->assertTrue($view->vars['list_is_synchronized']);
     }
 
     public function getTestViewProvider(): array
@@ -168,6 +170,22 @@ public function getTestSubmitInvalidProvider(): array
         ];
     }
 
+    public function testSubmitInvalidByValidator(): void
+    {
+        $field = $this->factory->create(EntityAjaxType::class, null, [
+            'class' => Tag::class,
+            'route_name' => 'fake_route',
+            'multiple' => false,
+            'constraints' => [new Blank()],
+        ]);
+
+        $field->submit('2');
+
+        $this->assertTrue($field->isSynchronized());
+        $this->assertFalse($field->isValid());
+        $this->assertSame(['2' => 'tag2'], $field->getViewData());
+    }
+
     /**
      * @dataProvider getTestSubmitWithQueryBuilderProvider
      */