Skip to content

Added API allows ISV to specify preferred launch mode#1443

Merged
betamaxbandit merged 1 commit intoeclipse-cdt:mainfrom
DangMinhTam382:Add_API_to_allow_set_default_launch_mode
Apr 15, 2026
Merged

Added API allows ISV to specify preferred launch mode#1443
betamaxbandit merged 1 commit intoeclipse-cdt:mainfrom
DangMinhTam382:Add_API_to_allow_set_default_launch_mode

Conversation

@DangMinhTam382
Copy link
Copy Markdown
Contributor

Added API to ILaunchConfigurationProvider that provide preferred launch mode ID for specified launch descriptor and launch target. Preferred mode is considered when LaunchBarManger call syncActiveMode(). Preferred mode comes after storedMode, lastActiveMode and comes before hard-coded run, debug, first supported mode.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Test Results

  182 files  ±0    182 suites  ±0   2m 41s ⏱️ +8s
4 718 tests ±0  4 709 ✅ ±0  9 💤 ±0  0 ❌ ±0 
4 718 runs  +2  4 709 ✅ +2  9 💤 ±0  0 ❌ ±0 

Results for commit 580c87e. ± Comparison against base commit d5944a6.

♻️ This comment has been updated with latest results.

@DangMinhTam382 DangMinhTam382 force-pushed the Add_API_to_allow_set_default_launch_mode branch 2 times, most recently from 7d8475c to 800ff55 Compare April 7, 2026 12:21
Added API to ILaunchConfigurationProvider that provide preferred launch
mode ID for specified launch descriptor and launch target.
Preferred mode is considered when LaunchBarManger call syncActiveMode().
Preferred mode comes after storedMode, lastActiveMode and comes before
hard-coded run, debug, first supported mode.
@DangMinhTam382 DangMinhTam382 force-pushed the Add_API_to_allow_set_default_launch_mode branch from 800ff55 to 580c87e Compare April 7, 2026 12:34
@DangMinhTam382
Copy link
Copy Markdown
Contributor Author

Hi Mr. @jonahgraham ,

This PR is ready for review now.
Could you please have a look at it?

Many Thanks!

@jonahgraham
Copy link
Copy Markdown
Member

@betamaxbandit Can you do a first review + approval on this please? If you have no concerns, please go ahead and merge it too.

Copy link
Copy Markdown
Contributor

@betamaxbandit betamaxbandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DangMinhTam382 ,
LGTM.
Thank you very much for submitting this PR.
Cheers John

@betamaxbandit betamaxbandit merged commit acd4556 into eclipse-cdt:main Apr 15, 2026
4 checks passed
@betamaxbandit
Copy link
Copy Markdown
Contributor

@betamaxbandit Can you do a first review + approval on this please? If you have no concerns, please go ahead and merge it too.

Hi @jonahgraham ,
I have now merged this.
I think I need to set the milestone, but not sure. Is it simply 12.5.0?

@jonahgraham
Copy link
Copy Markdown
Member

Wonderful - Thanks @DangMinhTam382 for the contribution and thanks @betamaxbandit for review.

I think I need to set the milestone, but not sure. Is it simply 12.5.0?

Thank you - and yes, just 12.5.0 is ideal.

@betamaxbandit betamaxbandit added this to the 12.5.0 milestone Apr 15, 2026
@DangMinhTam382
Copy link
Copy Markdown
Contributor Author

Super! Thanks @betamaxbandit and @jonahgraham for reviewing and merging this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants