From 85284f05b7af0f31e02c15913fe58eebdd440a6c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20T=C3=A4nzer?= Date: Fri, 9 Jan 2026 16:28:46 +0100 Subject: [PATCH 1/2] Setting to allow clangd to detect system headers Also cleaned up vscode configuration. --- .vscode/settings.json | 28 +++++++++++++++++++--------- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index 47cb954..dd46b06 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -5,12 +5,10 @@ "files.trimTrailingWhitespace": true, "editor.insertSpaces": true, "editor.tabCompletion": "on", - // Default for any filetype "editor.rulers": [ 99 ], - // Exclude build, temp and cache folders "files.watcherExclude": { ".*/**": true, @@ -19,7 +17,6 @@ ".venv*/**": true, "_build/**": true, }, - // Python Settings // Exclude build, temp and cache folders "python.analysis.exclude": [ @@ -42,13 +39,13 @@ }, "editor.defaultFormatter": "charliermarsh.ruff", }, - // Markdown Settings "[markdown]": { // We mostly write markdown in some combination with python, // so we use the same rulers as python. "editor.rulers": [ - 79, 99 + 79, + 99 ] }, @@ -62,6 +59,12 @@ "[restructuredtext]": { "editor.tabSize": 3, }, + // Patch files + "[diff]": { + "files.insertFinalNewline": false, + "files.trimFinalNewlines": false, + "files.trimTrailingWhitespace": false, + }, // // // Esbonio 0.x (Current) @@ -80,9 +83,11 @@ // // // Esbonio 1.x (Preview) - "esbonio.sphinx.pythonCommand": [ - ".venv_docs/bin/python" - ], + "esbonio.sphinx.pythonCommand": { + "command": [ + ".venv_docs/bin/python" + ] + }, "esbonio.sphinx.buildCommand": [ "docs", "_build", @@ -99,8 +104,13 @@ "--ignore-glob=bazel-*/*", "--ignore-glob=.venv_docs/*", "--ignore-glob=_build/*", - ], "python.testing.unittestEnabled": false, "python.testing.pytestEnabled": true, + "clangd.arguments": [ + "--compile-commands-dir=${workspaceFolder}/", + "--pretty", + "--background-index", + "--query-driver=/var/cache/bazel/*/execroot/_main/external/toolchains_llvm++llvm+llvm_toolchain/bin/cc_wrapper.sh" + ], } From c1e7d34c3efa1f467d3e53398e9fbac69a691271 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20T=C3=A4nzer?= Date: Fri, 9 Jan 2026 16:31:02 +0100 Subject: [PATCH 2/2] Don't fetch startpls_server via bazel It is already present in the devcontainer. Addresses eclipse-score/tooling#79 --- .vscode/extensions.json | 7 ++----- .vscode/settings.json | 7 ------- BUILD | 7 +------ 3 files changed, 3 insertions(+), 18 deletions(-) diff --git a/.vscode/extensions.json b/.vscode/extensions.json index ce87b69..3273aef 100644 --- a/.vscode/extensions.json +++ b/.vscode/extensions.json @@ -2,20 +2,17 @@ "recommendations": [ // Editing *.drawio.svg files directly in VS Code "hediet.vscode-drawio", - // Some convenient extensions for editing reStructuredText files "lextudio.restructuredtext", - // Linting and live preview for score docs "swyddfa.esbonio", - // ErrorLens highlights errors and warnings in your code / docs "usernamehw.errorlens", - // Linting and formatting for Python (LSP via ruff server) "charliermarsh.ruff", - // BasedPyright for python various type checking improvements and pylance features "detachhead.basedpyright", + // Bazel BUILD integration + "bazelbuild.vscode-bazel", ] } diff --git a/.vscode/settings.json b/.vscode/settings.json index dd46b06..7534578 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -48,13 +48,6 @@ 99 ] }, - - "bazel.lsp.command": "bazel", - "bazel.lsp.args": [ - "run", - "//:starpls_server" - ], - // RST Settings "[restructuredtext]": { "editor.tabSize": 3, diff --git a/BUILD b/BUILD index 473b5d5..14752d2 100644 --- a/BUILD +++ b/BUILD @@ -12,14 +12,9 @@ # ******************************************************************************* load("@score_docs_as_code//:docs.bzl", "docs") -load("@score_tooling//:defs.bzl", "copyright_checker", "dash_license_checker", "setup_starpls", "use_format_targets") +load("@score_tooling//:defs.bzl", "copyright_checker", "dash_license_checker", "use_format_targets") load("//:project_config.bzl", "PROJECT_CONFIG") -setup_starpls( - name = "starpls_server", - visibility = ["//visibility:public"], -) - copyright_checker( name = "copyright", srcs = [