fix: only increment depth counter for new projects in cycle detection

Fixed bug where currentDepth was unconditionally incremented in
beginResolvingProject(), causing potential counter mismatches.
Now only increments when project is actually added to processedProjects.

Removed redundant cycle checks in calling code since the method now
handles duplicate projects correctly on its own.

Author: runchen0919

bundles/com.salesforce.bazel.eclipse.core/src/com/salesforce/bazel/eclipse/core/classpath/BazelClasspathContainerRuntimeResolver.java

@@ -263,6 +263,11 @@ private boolean populateWithSavedContainer(IJavaProject project, ContainerResolu
                             // remove from stack again when done resolving
                             resolutionContext.endResolvingProject(sourceProject);
                         }
+                    } else if (LOG.isDebugEnabled()) {
+                        LOG.debug(
+                            "Skipping already processed project '{}' in thread '{}' to avoid cycle",
+                            sourceProject.getName(),
+                            Thread.currentThread().getName());
                     }
                     break;
                 }
@@ -372,7 +377,7 @@ public IRuntimeClasspathEntry[] resolveRuntimeClasspathEntry(IRuntimeClasspathEn
         // therefore we use a ThreadLocal LinkedHashSet to keep track of recursive attempts
         var resolutionContext = currentThreadResolutionContet.get();
 
-        // CRITICAL: Check if this is top-level BEFORE incrementing depth
+        // CRITICAL: Check if this is top-level BEFORE calling beginResolvingProject
         // This ensures ThreadLocal cleanup happens correctly
         var isTopLevelResolution = resolutionContext.currentDepth == 0;
 
@@ -386,16 +391,6 @@ public IRuntimeClasspathEntry[] resolveRuntimeClasspathEntry(IRuntimeClasspathEn
             return new IRuntimeClasspathEntry[0];
         }
 
-        // Now safe to increment depth counter
-        if (!resolutionContext.beginResolvingProject(project.getProject())) {
-            // This should never happen now due to the check above, but keep as safety net
-            LOG.error(
-                "Unexpected state: beginResolvingProject returned false after cycle check for project '{}' in thread '{}'",
-                project.getProject().getName(),
-                Thread.currentThread().getName());
-            return new IRuntimeClasspathEntry[0];
-        }
-
         var stopWatch = StopWatch.startNewStopWatch();
         try {
             // try the saved container