Renmaing of location in ei 3.12

[romainsacchi]

@cmutel From the ei312's report of changes:

Following the reporting changes of IAI, the regions of ‘IAI Area, EU27 & EFTA’ and ‘IAI Area, Russia & RER w/o EU27 & EFTA’ have been adapted and renamed ‘IAI Area, Western and Central Europe’ and ‘IAI Area, Russia and Eastern Europe’ respectively.

This indeed causes issues, notably in premise.
I'm not sure how that should be dealt with in constructive_geometries.

I don't know whether adding a renamed "duplicate" entry here would do the trick, or whether that would cause conflicts with the existing "IAI Area, EU27 & EFTA" entry.

[cmutel]

Thanks @romainsacchi. Do you know if these are the only changes?

To support these changes, we would need to:

1. Change the names in the file you indicated
2. Add a mapping from the old name in compatibility.py
3. Add a test to make sure we get the desired behaviour.

If you can confirm these are the only changes, I can do the rest 😃

[romainsacchi]

Hi @cmutel indeed, from what I gather from the change report and what I could see in the data itself, these two locations (IAI EU and IAI Russia) are the only ones that changed.

[romainsacchi]

So:

IAI Area, Russia & RER w/o EU27 & EFTA -> IAI Area, Russia and Eastern Europe

and

IAI Area, EU27 & EFTA -> IAI Area, Western and Central Europe

[cmutel]

Check to make sure the following are also defined:

• Asia without China
• GQ
• UN-SAMERICA

[romainsacchi]

@cmutel the three locations you list above are all declared under https://github.com/ecoinvent/constructive_geometries/blob/main/constructive_geometries/data/faces.json

[romainsacchi]

And all three are used by ei 3.12 with this exact spelling.

[cmutel]

And all three are used by ei 3.12 with this exact spelling.

Yeah, that's why I made the comment to check on them 😉

[romainsacchi]

@cmutel sorry, I forgot to follow up. Should we go forward with this, or do you want me to check anything else?

[romainsacchi]

Actually, I do occasionally see also:

US-PR not found in regex
IN-DD not found in regex

which I believe also comes from constructive-geometries 1.0.