Add claude GitHub actions 1775261461125

[wsiemens]

No description provided.

[mmfofana]

Code review

Found 6 issues:

1. SSE event schema uses prev_price and change_pct as field names, but the backend's PriceUpdate.to_dict() already emits previous_price and change_percent — frontend code built against this spec will fail to find the correct keys at runtime.

finally/planning/PLAN.md

Lines 270 to 286 in 35068c9

	```json
	{
	"ticker": "AAPL",
	"price": 191.42,
	"prev_price": 191.10,
	"prev_close": 189.50,
	"change": 0.32,
	"change_pct": 0.17,
	"day_change": 1.92,
	"day_change_pct": 1.01,
	"direction": "up",
	"timestamp": "2026-03-31T12:00:00.000Z"
	}
	```
	`direction` is `"up"`, `"down"`, or `"unchanged"`. `change`/`change_pct` are tick-over-tick. `day_change`/`day_change_pct` are relative to `prev_close`.
	### Portfolio

2. SSE schema documents direction as "up", "down", or "unchanged", but the implemented PriceUpdate.direction property returns "flat" (not "unchanged") when price is unchanged — the no-change visual state will silently break on the frontend.

finally/planning/PLAN.md

Lines 282 to 286 in 35068c9

	}
	```
	`direction` is `"up"`, `"down"`, or `"unchanged"`. `change`/`change_pct` are tick-over-tick. `day_change`/`day_change_pct` are relative to `prev_close`.
	### Portfolio

3. .claude/settings.local.json is committed to the repo with "Bash(codex exec:*)" — a wildcard shell-execution permission. Local settings files are machine-specific by convention and should be gitignored; committing this auto-grants unrestricted codex exec access to all contributors and CI sessions.

finally/.claude/settings.local.json

Lines 5 to 10 in 35068c9

	"WebFetch(domain:polygon.io)",
	"WebFetch(domain:massive.com)",
	"Bash(codex exec:*)",
	"Skill(update-config)"
	]
	}

4. planning/MARKET_DATA_SUMMARY.md is deleted, but CLAUDE.md line 5 still references it by name ("summarized in the file planning/MARKET_DATA_SUMMARY.md"). Every future agent session will follow a dead reference.

finally/CLAUDE.md

Lines 4 to 7 in 14550e1

	The key document is PLAN.md included in full below; the market data component has been completed and is summarized in the file `planning/MARKET_DATA_SUMMARY.md` with more details in the `planning/archive` folder. Consult these docs only when required. The remainder of the platform is still to be developed.
	@planning/PLAN.md

5. README.md Quick Start instructs users to run ./scripts/start_mac.sh, but this file does not exist. Per planning/PLAN.md, the script should be named start.sh, and the scripts/ directory has not yet been created — users following the README will get a "No such file" error.

finally/README.md

Lines 18 to 23 in 35068c9

	# Start (macOS/Linux)
	./scripts/start_mac.sh
	# Start (Windows PowerShell)
	./scripts/start_windows.ps1

6. The Stop hook fires unconditionally at the end of every Claude session and auto-writes to planning/REVIEW.md via codex exec with no scoping or conditions — this will run in unrelated sessions and bypass normal tool-use review.

finally/independent-reviewer/hooks/hooks.json

Lines 5 to 11 in 35068c9

	"hooks": [
	{
	"type": "command",
	"command": "codex exec \"Review changes since last commit and write changes to planning/REVIEW.md\""
	}
	]
	}

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}