Add tests to lift coverage above 80%#2
Open
longbiaochen wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds new Vitest coverage for several utility modules (strings, money, dates, arrays) to validate expected formatting and helper behaviors.
Changes:
- Expanded
stringstest suite to coverslugify,truncate,titleCase, andescapeHtml - Added new test suites for
money,dates, andarraysutility modules - Introduced edge-case assertions for non-positive inputs (e.g., chunk size, recipient count, max length, fee rate)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/strings.test.ts | Adds tests for additional string helpers and more slugify scenarios |
| src/money.test.ts | Introduces tests for currency formatting, fee rounding, payouts, and even splits |
| src/dates.test.ts | Adds tests for date math helpers (day diffs, weekends, shifting, UTC normalization) |
| src/arrays.test.ts | Adds tests for chunking, deduplication, and grouping logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+16
to
+21
| expect(isWeekend(new Date("2026-05-23T12:00:00Z"))).toBe(true); | ||
| expect(isWeekend(new Date("2026-05-24T12:00:00Z"))).toBe(true); | ||
| }); | ||
|
|
||
| it("returns false for weekdays", () => { | ||
| expect(isWeekend(new Date("2026-05-25T12:00:00Z"))).toBe(false); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Coverage summary after this change:
TaskBounty