From a8ac7dea4b8842dcbb184fca737c66c50193cacc Mon Sep 17 00:00:00 2001 From: Damian Stachura Date: Wed, 26 Nov 2025 18:20:06 +0100 Subject: [PATCH 1/2] Fix score_details type from string into object --- schema/eval.schema.json | 2 +- schema/eval_types.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/schema/eval.schema.json b/schema/eval.schema.json index 7246f81..65c8acf 100644 --- a/schema/eval.schema.json +++ b/schema/eval.schema.json @@ -264,7 +264,7 @@ } }, "score_details": { - "type": "string", + "type": "object", "description": "The score for the evaluation and related details", "required": [ "score" diff --git a/schema/eval_types.py b/schema/eval_types.py index 5b6870f..1c8105a 100644 --- a/schema/eval_types.py +++ b/schema/eval_types.py @@ -1,6 +1,6 @@ # generated by datamodel-codegen: # filename: eval.schema.json -# timestamp: 2025-11-18T23:38:04+00:00 +# timestamp: 2025-11-26T17:19:09+00:00 from __future__ import annotations From 871de9ad7b6656725595ac35ff89d7c9355c1dc0 Mon Sep 17 00:00:00 2001 From: Damian Stachura Date: Wed, 26 Nov 2025 18:25:58 +0100 Subject: [PATCH 2/2] Forbid additional properties in schema on top-level --- schema/eval.schema.json | 2 +- schema/eval_types.py | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/schema/eval.schema.json b/schema/eval.schema.json index 65c8acf..0c89dbf 100644 --- a/schema/eval.schema.json +++ b/schema/eval.schema.json @@ -13,6 +13,7 @@ "model_info", "evaluation_results" ], + "additionalProperties": false, "properties": { "schema_version": { "type": "string", @@ -264,7 +265,6 @@ } }, "score_details": { - "type": "object", "description": "The score for the evaluation and related details", "required": [ "score" diff --git a/schema/eval_types.py b/schema/eval_types.py index 1c8105a..7216a23 100644 --- a/schema/eval_types.py +++ b/schema/eval_types.py @@ -1,13 +1,13 @@ # generated by datamodel-codegen: # filename: eval.schema.json -# timestamp: 2025-11-26T17:19:09+00:00 +# timestamp: 2025-11-26T17:25:26+00:00 from __future__ import annotations from enum import Enum from typing import Any, Dict, List, Optional, Union -from pydantic import BaseModel, Field +from pydantic import BaseModel, ConfigDict, Field class SourceData(BaseModel): @@ -168,6 +168,9 @@ class DetailedEvaluationResultsPerSample(BaseModel): class EvaluationLog(BaseModel): + model_config = ConfigDict( + extra='forbid', + ) schema_version: str = Field( ..., description='Version of the schema used for this evaluation data' )