Skip to content
This repository was archived by the owner on Jan 13, 2022. It is now read-only.
This repository was archived by the owner on Jan 13, 2022. It is now read-only.

RFP: cpu profiling through /prof-cpu-on  #37

@rrh

Description

@rrh

I'm using the convenient oss-performance driver script to run real frameworks.

I want to be able to run the HHVM under test (UUT) compiled with GOOGLE_CPU_PROFILER. I currently set the env variable CPUPROFILE to name the file to dump profile info to when the UUT exit's cleanly, but if I happen to run the oss-performance driver script itself with a HHVM that was also compiled for google performance, then the CPUPROFILE env var will control both invocations of HHVM, and chaos ensues in regards to which HHVM really wrote the file named by CPUPROFILE.

Perhaps the oss-performance driver script could, under yet another flag, probe for the admin server requests /prof-cpu-on and /prof-cpu-off and if present, then have the admin server on the UUT turn on/off the profiler itself, and then the obnoxious CPUPROFILE env var wouldn't be needed.

Yeah, creeping featurism

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions