Skip to content

non-void-return issue in 3.0.0 #129

@dhzl84

Description

@dhzl84

Expected behavior

Version 3.0.0 should not throw return type errors fixed with #121.

Actual behavior

Eventhough PlatformIO states that it downloaded version 3.0.0, the functions in the downloaded code still have the return type bool.

Builds fail locally as well as on GH Actions.

Steps to reporduce the behavior

I use PlatformIO to get the library.

platformio.ini:

lib_deps = 
	finitespace/BME280 @ ^3.0.0

Library Installation by PlatformIO:

Library Manager: Installing finitespace/BME280 @ ^3.0.0
Downloading...
Unpacking...
Library Manager: BME280 @ 3.0.0 has been installed!

PlatformIO build console:

Dependency Graph
|-- <BME280> 3.0.0
.pio\libdeps\8266_thermostat_debug\BME280\src\BME280.cpp: In member function 'bool BME280::InitializeFilter()':
.pio\libdeps\8266_thermostat_debug\BME280\src\BME280.cpp:85:1: error: no return statement in function returning non-void [-Werror=return-type]
   85 | }
      | ^
.pio\libdeps\8266_thermostat_debug\BME280\src\BME280.cpp: In member function 'bool BME280::WriteSettings()':
.pio\libdeps\8266_thermostat_debug\BME280\src\BME280.cpp:122:1: error: no return statement in function returning non-void [-Werror=return-type]
  122 | }
      | ^

There seems to be an issue in the library registry.
Version 3.0.0 has two release dates, maybe same version published twice?
I browsed the history of my platformio.ini and already used version 3.0.0 in January 2020.

image

and

image

Hope you find the time to have a look into that?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions