Not returning required flag for trailing CR LF

[toptensoftware]

If a string ends with '\r\n' the final returned line break position doesn't have the 'required' flag set.

This line should include a check and return appropriately:

linebreak/src/linebreaker.js

Line 194 in 9096a22

return new Break(this.string.length);

eg: perhaps this:

var required = (this.curClass === BK) || ((this.curClass === CR) && (this.nextClass !== LF));
return new Break(this.string.length, required)

[lionel-rowe]

This isn't specific to CRLF, it happens with trailing line breaks of all kinds (LF, CRLF, CR).

// (using https://github.com/foliojs/linebreak/pull/50)
for (const lineBreak of ['\n', '\r\n', '\r']) {
  console.log([...new LineBreaker(['a', 'b', ''].join(lineBreak))]);
}

// [
//   { substring: 'a\n', position: 2, required: true },
//   { substring: 'b\n', position: 4, required: false }
// ]
// [
//   { substring: 'a\r\n', position: 3, required: true },
//   { substring: 'b\r\n', position: 6, required: false }
// ]
// [
//   { substring: 'a\r', position: 2, required: true },
//   { substring: 'b\r', position: 4, required: false }
// ]