logical error in convert_cmdbuf

[Zibri]

The correct way to escape a command is:

Example

1. escape the command
2. apply the hdlc checksum
3. escape the checksum

Your rotine does only the first one
But it will give error if the checksum contains 7e,7d or 5d.

Regards.
Zibri

[Zibri]

hmm Update: depending on hdlc implementation this varies.. sometimes it's like I said and sometimes not...
I recommend doing some tests...
for example writing an nvram variable containing 7e 7d 5d and 5e would be a good test:

like:

26 xx xx 7e 7d 00 00

should translate to

26 xx xx 7d 5e 7d 5d 00 00
then the crc is calculated
but if the crc contains 7d or 7e it should be escaped too

[Zibri]

an example is:
26 03 25 which becomes
26 03 25 e9 4f 7e
and
26 03 26
which becomes
26 03 26 72 7d 7e but the checksum must be escaped too
and it becomes
26 03 26 72 7d 5d 7e

[Zibri]

The right way is:

1. command: 26 03 26
2. add checksum: 26 03 26 72 7d
3. escape 7d and 7e: 26 03 26 72 7d 5d
4. add 7e: 26 03 26 72 7d 5d 7e

[Zibri]

you also have another error in the way you handle the serial port.
If you need help just say it.