Fix PSScriptAnalyzer: move $null to left side of comparisons

franckferman · franckferman · commit 37120e714f88 · 2026-03-27T10:26:18.000+01:00
diff --git a/scripts/Check-All.ps1 b/scripts/Check-All.ps1
@@ -191,7 +191,7 @@ if ($Stats) {
     $up = $null
   }
   
-  if ($up -ne $null) {
+  if ($null -ne $up) {
     $down = $total - $up
     "{0} total machines found, {1} reachable, {2} unreachable, {3:p1} reachability" -f $total, $up, $down, ($up / [double]([math]::Max($total, 1))) | Write-Host
   }
diff --git a/scripts/Check-Clients.ps1 b/scripts/Check-Clients.ps1
@@ -174,7 +174,7 @@ if ($Stats) {
     $up = $null
   }
   
-  if ($up -ne $null) {
+  if ($null -ne $up) {
     $down = $total - $up
     "{0} total, {1} reachable, {2} unreachable, {3:p1} reachability" -f $total, $up, $down, ($up / [double]([math]::Max($total, 1))) | Write-Host
   }
diff --git a/scripts/Check-Servers.ps1 b/scripts/Check-Servers.ps1
@@ -194,7 +194,7 @@ if ($Stats) {
     $up = $null
   }
   
-  if ($up -ne $null) {
+  if ($null -ne $up) {
     $down = $total - $up
     "{0} total, {1} reachable, {2} unreachable, {3:p1} reachability" -f $total, $up, $down, ($up / [double]([math]::Max($total, 1))) | Write-Host
   }

Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,7 @@ if ($Stats) {`
`191`	`191`	`$up = $null`
`192`	`192`	`}`
`193`	`193`
`194`		`- if ($up -ne $null) {`
	`194`	`+ if ($null -ne $up) {`
`195`	`195`	`$down = $total - $up`
`196`	`196`	`"{0} total machines found, {1} reachable, {2} unreachable, {3:p1} reachability" -f $total, $up, $down, ($up / [double]([math]::Max($total, 1))) \| Write-Host`
`197`	`197`	`}`
Original file line number	Diff line number	Diff line change
`@@ -174,7 +174,7 @@ if ($Stats) {`
`174`	`174`	`$up = $null`
`175`	`175`	`}`
`176`	`176`
`177`		`- if ($up -ne $null) {`
	`177`	`+ if ($null -ne $up) {`
`178`	`178`	`$down = $total - $up`
`179`	`179`	`"{0} total, {1} reachable, {2} unreachable, {3:p1} reachability" -f $total, $up, $down, ($up / [double]([math]::Max($total, 1))) \| Write-Host`
`180`	`180`	`}`
Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ if ($Stats) {`
`194`	`194`	`$up = $null`
`195`	`195`	`}`
`196`	`196`
`197`		`- if ($up -ne $null) {`
	`197`	`+ if ($null -ne $up) {`
`198`	`198`	`$down = $total - $up`
`199`	`199`	`"{0} total, {1} reachable, {2} unreachable, {3:p1} reachability" -f $total, $up, $down, ($up / [double]([math]::Max($total, 1))) \| Write-Host`
`200`	`200`	`}`