Skip to content

Commit 10814ce

Browse files
AngeloGioacchino Del Regnofrank-w
authored andcommitted
arm64: dts: mediatek: mt7988a: Fix PCI-Express T-PHY node address
The PCIe and USB TPHYs are under the soc bus, which provides MMIO, and all nodes under that must use the bus, otherwise those would clearly be out of place. Add ranges to both the tphy(s) and assign the address to the main node to silence a dtbs_check warning, and fix the children to use the MMIO range of t-phy. Fixes: ("f693e6ba55ae arm64: dts: mediatek: mt7988: Add t-phy for ssusb1") Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
1 parent e3d41c4 commit 10814ce

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

arch/arm64/boot/dts/mediatek/mt7988a.dtsi

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -685,20 +685,20 @@
685685
tphy: t-phy@11c50000 {
686686
compatible = "mediatek,mt7986-tphy",
687687
"mediatek,generic-tphy-v2";
688-
#address-cells = <2>;
689-
#size-cells = <2>;
690-
ranges;
688+
#address-cells = <1>;
689+
#size-cells = <1>;
690+
ranges = <0 0 0x11c50000 0x1000>;
691691
status = "disabled";
692692

693-
tphyu2port0: usb-phy@11c50000 {
694-
reg = <0 0x11c50000 0 0x700>;
693+
tphyu2port0: usb-phy@0 {
694+
reg = <0 0x700>;
695695
clocks = <&infracfg CLK_INFRA_USB_UTMI_CK_P1>;
696696
clock-names = "ref";
697697
#phy-cells = <1>;
698698
};
699699

700-
tphyu3port0: usb-phy@11c50700 {
701-
reg = <0 0x11c50700 0 0x900>;
700+
tphyu3port0: usb-phy@700 {
701+
reg = <0x700 0x900>;
702702
clocks = <&infracfg CLK_INFRA_USB_PIPE_CK_P1>;
703703
clock-names = "ref";
704704
#phy-cells = <1>;
@@ -715,20 +715,20 @@
715715
xsphy: xs-phy@11e10000 {
716716
compatible = "mediatek,mt7988-xsphy",
717717
"mediatek,xsphy";
718-
#address-cells = <2>;
719-
#size-cells = <2>;
720-
ranges;
718+
#address-cells = <1>;
719+
#size-cells = <1>;
720+
ranges = <0 0 0x11e10000 0x3900>;
721721
status = "disabled";
722722

723-
xphyu2port0: usb-phy@11e10000 {
724-
reg = <0 0x11e10000 0 0x400>;
723+
xphyu2port0: usb-phy@0 {
724+
reg = <0 0x400>;
725725
clocks = <&infracfg CLK_INFRA_USB_UTMI>;
726726
clock-names = "ref";
727727
#phy-cells = <1>;
728728
};
729729

730-
xphyu3port0: usb-phy@11e13000 {
731-
reg = <0 0x11e13400 0 0x500>;
730+
xphyu3port0: usb-phy@3400 {
731+
reg = <0x3400 0x500>;
732732
clocks = <&infracfg CLK_INFRA_USB_PIPE>;
733733
clock-names = "ref";
734734
#phy-cells = <1>;

0 commit comments

Comments
 (0)