From db3f5f4ff0732327e659c5f23a18e209bfcef19c Mon Sep 17 00:00:00 2001 From: Aditya Sirish <8928778+adityasaky@users.noreply.github.com> Date: Fri, 6 Mar 2026 12:22:32 -0500 Subject: [PATCH] Revert "Reduce fetch depth to 1" --- internal/webhook/webhook.go | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/internal/webhook/webhook.go b/internal/webhook/webhook.go index 10c7e9b7..d71ecb0c 100644 --- a/internal/webhook/webhook.go +++ b/internal/webhook/webhook.go @@ -25,7 +25,6 @@ import ( githubopts "github.com/gittuf/gittuf/experimental/gittuf/options/github" rslopts "github.com/gittuf/gittuf/experimental/gittuf/options/rsl" verifymergeableopts "github.com/gittuf/gittuf/experimental/gittuf/options/verifymergeable" - "github.com/gittuf/gittuf/pkg/gitinterface" "github.com/go-git/go-git/v5" "github.com/go-git/go-git/v5/plumbing" "github.com/google/go-github/v61/github" @@ -270,7 +269,7 @@ func (g *GittufApp) handlePush(ctx context.Context, event *github.PushEvent) err if err != nil { return err } - if _, err := git.PlainClone(localDirectory, false, &git.CloneOptions{URL: cloneURL, Depth: 1}); err != nil { + if _, err := git.PlainClone(localDirectory, false, &git.CloneOptions{URL: cloneURL}); err != nil { log.Default().Printf("Unable to clone repository: %v", err) return err } @@ -289,7 +288,7 @@ func (g *GittufApp) handlePush(ctx context.Context, event *github.PushEvent) err switch { case strings.HasPrefix(ref, "refs/heads"): refSpec := fmt.Sprintf("%s:refs/gittuf/local-ref", ref) - if err := gitRepo.FetchRefSpec("origin", []string{refSpec}, gitinterface.WithFetchDepth(1)); err != nil { + if err := gitRepo.FetchRefSpec("origin", []string{refSpec}); err != nil { log.Default().Printf("Unable to fetch pushed branch: %v", err) return err } @@ -374,7 +373,7 @@ func (g *GittufApp) handlePullRequest(ctx context.Context, event *github.PullReq if err != nil { return err } - if _, err := git.PlainClone(localDirectory, false, &git.CloneOptions{URL: cloneURL, Depth: 1, ReferenceName: plumbing.ReferenceName(baseRef)}); err != nil { + if _, err := git.PlainClone(localDirectory, false, &git.CloneOptions{URL: cloneURL, ReferenceName: plumbing.ReferenceName(baseRef)}); err != nil { log.Default().Printf("Unable to clone repository: %v", err) return err } @@ -391,7 +390,7 @@ func (g *GittufApp) handlePullRequest(ctx context.Context, event *github.PullReq } refSpec := fmt.Sprintf("refs/pull/%d/head:refs/pull/%d/head", pullRequestNumber, pullRequestNumber) - if err := gitRepo.FetchRefSpec("origin", []string{refSpec}, gitinterface.WithFetchDepth(1)); err != nil { + if err := gitRepo.FetchRefSpec("origin", []string{refSpec}); err != nil { log.Default().Printf("Unable to fetch feature branch: %v", err) return err } @@ -455,7 +454,7 @@ func (g *GittufApp) handlePullRequest(ctx context.Context, event *github.PullReq // Run this check in a separate goroutine for each // affected PR refSpec := fmt.Sprintf("refs/pull/%d/head:refs/pull/%d/head", pullRequest.GetNumber(), pullRequest.GetNumber()) - if err := gitRepo.FetchRefSpec("origin", []string{refSpec}, gitinterface.WithFetchDepth(1)); err != nil { + if err := gitRepo.FetchRefSpec("origin", []string{refSpec}); err != nil { log.Default().Printf("Unable to fetch feature branch for affected pull request %d: %v", pullRequest.GetNumber(), err) return } @@ -635,7 +634,7 @@ func (g *GittufApp) handlePullRequestReview(ctx context.Context, event *github.P if err != nil { return err } - if _, err := git.PlainClone(localDirectory, false, &git.CloneOptions{URL: cloneURL, Depth: 1, ReferenceName: plumbing.ReferenceName(baseRef)}); err != nil { + if _, err := git.PlainClone(localDirectory, false, &git.CloneOptions{URL: cloneURL, ReferenceName: plumbing.ReferenceName(baseRef)}); err != nil { log.Default().Printf("Unable to clone repository: %v", err) return err } @@ -655,7 +654,7 @@ func (g *GittufApp) handlePullRequestReview(ctx context.Context, event *github.P // We fetch using github's refs/pull//head ref as the feature ref // may be from a different repository refSpec := fmt.Sprintf("refs/pull/%d/head:refs/pull/%d/head", pullRequestNumber, pullRequestNumber) - if err := gitRepo.FetchRefSpec("origin", []string{refSpec}, gitinterface.WithFetchDepth(1)); err != nil { + if err := gitRepo.FetchRefSpec("origin", []string{refSpec}); err != nil { log.Default().Printf("Unable to fetch feature branch: %v", err) return err }