Skip to content

performance: use maps in conn.bind to avoid nested loops#180

Open
pquerna wants to merge 2 commits intoglebarez:masterfrom
pquerna:pq/bulk_insert_bind
Open

performance: use maps in conn.bind to avoid nested loops#180
pquerna wants to merge 2 commits intoglebarez:masterfrom
pquerna:pq/bulk_insert_bind

Conversation

@pquerna
Copy link

@pquerna pquerna commented Dec 18, 2024

  • When using INSERT ... VALUES() with a large number of rows, we found that we were spending a decent percentage of CPU time in the bind() function, specifically in the nested for loops inside bind -> we were looping over the args, and inside that looping over the entire arguments array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments