endOf("week") incorrectly evaluates to be the end of Monday

[william-tsai]

zen-engine version = 0.53.0

I'm using version 0.53.0.

When using the new d() syntax to get the end of the current week, d("America/Los_Angeles").endOf("week") would incorrectly evaluate to be the following Monday.

However, using the old date() syntax, endOf(date("now"), "week") would correctly evaluate to be this upcoming Sunday.

Even using the d("2024-01-15").endOf("week") example shown in the "Date operations" documentation, it'd incorrectly evaluate to be 2024-01-16T23:59:59Z (a Tuesday??) instead of 2024-01-21T23:59:59 (Sunday) that is shown in the documentation (see second screenshot below).

Please advise. Thank you!

------------------------------------------------------------------

[TheCaffinatedDeveloper]

The issue seems to be here

 DurationUnit::Week => {
                let weekday = date_time.weekday().num_days_from_sunday();

                date_time
                    .checked_add_days(Days::new(weekday.to_u64()?))?
                    .with_hour(23)?
                    .with_minute(59)?
                    .with_second(59)?
            }

num_days_from_sunday is from Chrono https://docs.rs/chrono/latest/chrono/enum.Weekday.html#method.num_days_from_sunday

So this actually represents "number of days since Sunday" not "Number of days until Sunday"