diff --git a/NEWS.md b/NEWS.md index 6e6756f..f1518e5 100644 --- a/NEWS.md +++ b/NEWS.md @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed +- Fixed `is_slave == false` (comparison instead of assignment) in `DivConformingFESpaces`, and simplified the boundary-facet branch by removing the now-redundant `if/else`. - Fixed `BlockPMatrix{V}(::UndefInitializer, rows, cols)` constructor dropping the `cols` argument, causing a `MethodError` at runtime. - Fixed `local_views(::BlockPMatrix, rows, cols)` indexing 1D block-range vectors with a 2D `CartesianIndex`, causing `BoundsError` for any multi-field problem with ≥2 fields. - Fixed `mul!(y::BlockPVector, A::BlockPMatrix, x::BlockPVector, α, β)` computing `α*β*(A*x)` instead of `α*(A*x) + β*y`; the 3-arg `mul!` was also updated to correctly zero `y` before accumulating. diff --git a/src/DivConformingFESpaces.jl b/src/DivConformingFESpaces.jl index 9e6b9ea..5975a0b 100644 --- a/src/DivConformingFESpaces.jl +++ b/src/DivConformingFESpaces.jl @@ -126,9 +126,7 @@ function _generate_sign_flips(model,cell_reffes) cells_around_facets, facet_gid) is_slave=false - if (length(facet_cells_around)==1) - is_slave == false - else + if length(facet_cells_around) > 1 mx=maximum(loc_to_glo[facet_cells_around]) is_slave = (loc_to_glo[cell] == mx) end