From abeb38611121983172924c71420f088c5a69989b Mon Sep 17 00:00:00 2001 From: Zubin Duggal Date: Wed, 26 Nov 2025 19:13:11 +0530 Subject: [PATCH 1/2] Use 9.10.2 instead of 9.10.3 for CI on windows 9.10.2 is currently broken with TH on windows. See https://gitlab.haskell.org/ghc/ghc/-/issues/26613 --- .github/workflows/test.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ca2abd0084..b4b1ea22a2 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -76,6 +76,11 @@ jobs: test: - true - false + include: + # 9.10.3 is broken on windows + - os: windows-latest + test: true + ghc: "9.10.2" exclude: # Exclude the test configuration on macos, it's sufficiently similar to other OSs # that it mostly just burns CI time. Buiding is still useful since it catches @@ -87,6 +92,9 @@ jobs: test: false - os: ubuntu-latest test: false + # 9.10.3 is broken on windows + - os: windows-latest + ghc: "9.10" steps: - uses: actions/checkout@v3 From 8f5824e7c7841424563beb92604581214d3096b5 Mon Sep 17 00:00:00 2001 From: Zubin Duggal Date: Wed, 26 Nov 2025 19:13:11 +0530 Subject: [PATCH 2/2] Use 9.10.2 instead of 9.10.3 for CI on windows 9.10.2 is currently broken with TH on windows. See https://gitlab.haskell.org/ghc/ghc/-/issues/26613 --- .github/workflows/test.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index b4b1ea22a2..da40f259f1 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -146,7 +146,7 @@ jobs: run: cabal test hls-refactor-plugin-tests || cabal test hls-refactor-plugin-tests # TODO enable when it supports 9.10 - - if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' + - if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.10.2' name: Test hls-floskell-plugin run: cabal test hls-floskell-plugin-tests || cabal test hls-floskell-plugin-tests @@ -163,7 +163,7 @@ jobs: run: cabal test hls-eval-plugin-tests || cabal test hls-eval-plugin-tests # TODO enable when it supports 9.10 - - if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' + - if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.10.2' name: Test hls-splice-plugin run: cabal test hls-splice-plugin-tests || cabal test hls-splice-plugin-tests @@ -196,7 +196,7 @@ jobs: run: cabal test hls-rename-plugin-tests || cabal test hls-rename-plugin-tests # TODO enable when it supports 9.10 - - if: matrix.test && matrix.ghc != '9.10' + - if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.10.2' name: Test hls-hlint-plugin test suite run: cabal test hls-hlint-plugin-tests || cabal test hls-hlint-plugin-tests @@ -233,7 +233,7 @@ jobs: run: cabal test hls-explicit-record-fields-plugin-tests || cabal test hls-explicit-record-fields-plugin-tests # versions need to be limited since the tests depend on cabal-fmt which only builds with ghc <9.10 - - if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' + - if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.10.2' name: Test hls-cabal-fmt-plugin test suite run: cabal test hls-cabal-fmt-plugin-tests --flag=isolateCabalfmtTests || cabal test hls-cabal-fmt-plugin-tests --flag=isolateCabalfmtTests @@ -246,7 +246,7 @@ jobs: run: cabal test hls-cabal-plugin-tests || cabal test hls-cabal-plugin-tests # TODO enable when it supports 9.10 - - if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' + - if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.10.2' name: Test hls-retrie-plugin test suite run: cabal test hls-retrie-plugin-tests || cabal test hls-retrie-plugin-tests @@ -264,7 +264,7 @@ jobs: # The plugin tutorial is only compatible with 9.6 and 9.8. # No particular reason, just to avoid excessive CPP. - - if: matrix.test && matrix.ghc != '9.4' && matrix.ghc != '9.10' && matrix.ghc != '9.12' + - if: matrix.test && matrix.ghc != '9.4' && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.10.2' name: Compile the plugin-tutorial run: cabal build plugin-tutorial