Commit c1bf74d
committed
fix(release): produce binaries under immutable releases + portable BSD sed
v0.2.0 shipped SOURCE-ONLY (regression from v0.1.1). Two bugs in the release
workflow, both confirmed from the failed v0.2.0 run (26694097435):
1. Immutable releases. `prepare` created a *published* release, then the build
matrix uploaded assets to it. The repo enabled immutable releases between
v0.1.1 (immutable:false) and v0.2.0 (immutable:true); immutable *published*
releases reject asset uploads — the linux leg died with "HTTP 422: Cannot
upload assets to an immutable release". Fix: create the release as a DRAFT,
upload all binaries + SHA256SUMS into the draft, then publish (--draft=false)
last so it seals atomically with all four assets.
2. BSD sed. The version-bake step (added in v0.2.0) used `sed -i "s/..."`, which
BSD sed on the macOS runners rejects ("extra characters at the end of l
command") — so macos-x64 and macos-arm64 failed before building. Fix:
`sed -i.bak ...` (portable across GNU + BSD) and remove the backups.
Verified locally: the compiler builds in release mode (ELF x86-64); `--version`
and `check` work; the bake substitutions match lib/version.ml + .build/dune-project.
v0.2.0 is immutable and cannot be amended, so the binaries are published via a
fresh v0.2.1 tag built with this fixed workflow. Refs ADR-019, #260 S2.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lz7pRcec2Z3tVtaAhvB3M81 parent 5a42e6e commit c1bf74d
1 file changed
Lines changed: 20 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
38 | 44 | | |
39 | 45 | | |
40 | 46 | | |
41 | 47 | | |
42 | 48 | | |
43 | 49 | | |
44 | 50 | | |
45 | | - | |
| 51 | + | |
46 | 52 | | |
47 | 53 | | |
48 | 54 | | |
| |||
75 | 81 | | |
76 | 82 | | |
77 | 83 | | |
78 | | - | |
79 | | - | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
80 | 92 | | |
81 | 93 | | |
82 | 94 | | |
| |||
107 | 119 | | |
108 | 120 | | |
109 | 121 | | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
0 commit comments