From 1166a3357308d58651c73541f52db39d94b5fba3 Mon Sep 17 00:00:00 2001 From: hyperpolymath <6759885+hyperpolymath@users.noreply.github.com> Date: Wed, 24 Jun 2026 15:11:10 +0100 Subject: [PATCH] fix(ci): clear three CI-hygiene drift failures - main.rs: drop unused SimulationResults import (errored under -D warnings) - ci-cd.yml: align Julia matrix + JULIA_VERSION to 1.12 (Manifest.toml is pinned to 1.12.x; CI was running 1.9/1.10 and failing on Statistics) - ci-cd.yml: remove bogus Pkg.add("Lint") / 'Run Julia Lint' step (Lint is not a registered package) Verified: cargo build (incl. -D warnings) clean in src/rust/. Co-Authored-By: Claude Opus 4.8 --- .github/workflows/ci-cd.yml | 12 +++--------- src/rust/src/main.rs | 2 +- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml index 3fbb254..dfe9477 100644 --- a/.github/workflows/ci-cd.yml +++ b/.github/workflows/ci-cd.yml @@ -14,7 +14,7 @@ permissions: contents: read env: - JULIA_VERSION: '1.10' + JULIA_VERSION: '1.12' RUST_VERSION: 'stable' REGISTRY: ghcr.io IMAGE_NAME: ${{ github.repository }} @@ -41,7 +41,7 @@ jobs: run: | cd src/julia/RobotVacuum julia --project=. -e 'using Pkg; Pkg.instantiate()' - julia --project=. -e 'using Pkg; Pkg.add("JuliaFormatter"); Pkg.add("Lint")' + julia --project=. -e 'using Pkg; Pkg.add("JuliaFormatter")' - name: Run JuliaFormatter (code formatting) run: | @@ -49,12 +49,6 @@ jobs: julia --project=. -e 'using JuliaFormatter; exit(format("src"; overwrite=false) ? 0 : 1)' continue-on-error: true - - name: Run Julia Lint - run: | - cd src/julia/RobotVacuum - julia --project=. -e 'using Pkg; Pkg.add("Lint"); using Lint; lintpkg("RobotVacuum")' - continue-on-error: true - # Security scanning security: name: Security Scanning @@ -122,7 +116,7 @@ jobs: contents: read strategy: matrix: - julia-version: ['1.9', '1.10', 'nightly'] + julia-version: ['1.12', 'nightly'] steps: - name: Checkout code uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 diff --git a/src/rust/src/main.rs b/src/rust/src/main.rs index c3d25e5..0a217c0 100644 --- a/src/rust/src/main.rs +++ b/src/rust/src/main.rs @@ -4,7 +4,7 @@ use clap::Parser; use env_logger::Env; use robot_vacuum_cleaner::{Robot, Environment, Simulator, Position}; -use robot_vacuum_cleaner::simulator::{SimulationConfig, SimulationResults}; +use robot_vacuum_cleaner::simulator::SimulationConfig; /// Robot Vacuum Cleaner Simulator #[derive(Parser, Debug)]