Conversation
maelle
commented
Jul 22, 2025
| SEXP l6 = PROTECT(Rf_ScalarString(PROTECT(Rf_mkChar(message)))); | ||
| SEXP l7 = PROTECT(Rf_lang3(l4, l5, l6)); | ||
| PROTECT(ec=Rf_eval(l7, rho)); | ||
| SEXP l4 = PROTECT(Rf_ScalarReal(percent)); |
Contributor
Author
There was a problem hiding this comment.
@schochastics if you agree we can remove the tk (not tkplot) stuff, I will need help with this C file. I am getting many errors from the current changes.
Contributor
|
In order to contribute, I need to first understand what this tk stuff was doing in the first place 😬 |
Contributor
Author
|
@schochastics I do wonder whether it was doing anything at all, depending on the verbose option, but let's ask in a future hackathon. |
Contributor
Author
|
@krlmlr could you please have a look when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not ready