-
-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or request
Description
Just raising a nit bug (?) I found.
When using multiple coverage actions, based on #35, I'm passing a different storage-subdirectory so that the saved XML reports on diff-storage branch don't overwrite each other.
However, another hidden requirement for multiple actions is a different path, since it's used as the sticky comment's unique key (header):
Lines 356 to 362 in 50449af
| - name: Post as comment | |
| if: contains(inputs.publish, 'true') | |
| uses: marocchino/sticky-pull-request-comment@v2 | |
| with: | |
| GITHUB_TOKEN: ${{ inputs.token }} | |
| header: ${{ inputs.path }} | |
| path: .coverage-output.final |
It would be nice to either:
- Create a separate input to handle the stick comments unique keys; or
- Document on the
pathdescription that it's used as the sticky comment unique key; or - Use
storage-subdirectoryas the unique key instead? Though it might fall into a similar problem we have with the currentpathhidden behavior, and may limit user shenanigans in case they want to have multiple actions overwriting each other's comments.
Sorry for the flood lately, no hurry here, as for now I can just pass different paths to the actions (which might be the intended way from the start).
Code of Conduct
- I agree to follow this project's Code of Conduct.
Contribution Guidelines
- I agree to follow this project's Contribution Guidelines.
Security Policy
- I agree to follow this project's Security Policy.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or request