No support for curve ed25519 keys

[almereyda]

The use of RSA keys is hard coded.

vault/bin/vault

Lines 51 to 60 in c239074

	selectKey: function(callback) {
	var client = new SSH(),
	snip = 12;
	client.requestIdentities(function(error, keys) {
	keys = keys.filter(function(k) { return k.type === 'ssh-rsa' });
	if (keys.length === 0)
	return callback(new Error('No usable RSA keys were found'));

Nowadays that ed25519 keys are also common, it could be nice to have them available for encryption/decryption, too.

[jcoglan]

Have you checked whether the existing code would work with ed25519 keys, if we removed the filter for ssh-rsa?

[almereyda]

Not yet, and not before end of October, since I'm moving houses.

[the-13th-letter]

Have you checked whether the existing code would work with ed25519 keys, if we removed the filter for ssh-rsa?

It would: ed25519 key signatures are deterministic, like RSA signatures. And does: I've had quite some success running this on a local fork of vault for the last few years.