Adding tag with semantic version release format

[sanrut01]

The pre-commit usage currently the best practice is using tags as revision rather than branches.
This helps us to use the previous version of the code base as well.

Can this project be tagged with the current code base by using semantic version format and can be taken further whenever a change is merged to master and have to be released

[jlebar]

Sounds reasonable to me. Patches welcome.

Would you also be willing to link to the documentation that explains the current best practice?

[sanrut01]

You can look for https://semver.org/
and there is some node package to use semantic release to manage but i also need to have look into it
https://github.com/semantic-release/semantic-release/tree/master/docs/usage
But as of now if we can tag with current branch then we can look into this as improvement to automate semantic release for our repo

[jlebar]

Is there documentation saying that in pre-commit specifically, the best practice is to use semver?

[sanrut01]

I haven't found any specific to pre-commit , when we use branch name for rev we get the warning below:
[WARNING] The 'rev' field of repo 'https://github.com/Lucas-C/pre-commit-hooks-nodejs' appears to be a mutable reference (moving tag / branch). Mutable references are never updated after the first install and are not supported. See https://pre-commit.com/#using-the-latest-version-for-a-repository for more details.

Ideally, when we use to tag the semantic version is the one that is used and suggested as best practice.

[jlebar]

OK, that warning makes sense.

Why not just type in a sha, though?

[sanrut01]

We can but whatever examples are other pre-commits i see they have used the tag everywhere rather than the hash.
Another scenario would what would be a case of rebasing if we use commit sha as the commit shas can change after rebase and tag may not be the same as of sha.

I am open to commit sha or semver somehow feel semver would be good

[jlebar]

Another scenario would what would be a case of rebasing if we use commit sha as the commit shas can change after rebase and tag may not be the same as of sha.

By design, git tags can't change. If you want a "tag-like thing" that can change, you want a branch. But then the thing that they're warning you about in the error you copied applies.

It seems like the Simplest Thing That Could Possibly Work would be to use sha's. Does that sound OK to you for now?

[sanrut01]

Sounds good. Please go ahead with creating the tag

[jlebar]

I was saying that we don't need a tag -- you can just use the sha.

…

On Thu, Nov 25, 2021, 1:35 AM sanrut01 ***@***.***> wrote: Sounds good. Please go ahead with creating the tag — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#20 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABEZB3DIX2JKGOTVQDF34LUNX7OVANCNFSM5ITSGBMQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[santhu3064]

Sorry i misread your precious message.
Sounds sensible will use the commit sha