From 6e0a335a257dd8fa279a4179ef637d9f539b9a2c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Go=C5=82e=CC=A8biowski-Owczarek?= Date: Tue, 23 Sep 2025 18:26:40 +0200 Subject: [PATCH 1/2] Release: Bump version in `package-lock.json` as well during the release --- build/release.js | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/build/release.js b/build/release.js index 92242abe..3e2d3132 100644 --- a/build/release.js +++ b/build/release.js @@ -18,6 +18,7 @@ var releaseVersion, nextVersion, isBeta, pkg, + pkgLock, prompt = enquirer.prompt, @@ -30,6 +31,7 @@ var releaseVersion, readmeFile = "README.md", packageFile = "package.json", + packageLockFile = "package-lock.json", versionFile = path.join( "src", "version.js" ), releaseDir = "CDN", @@ -99,6 +101,9 @@ function initialize( next ) { die( "No " + packageFile + " in this directory" ); } pkg = JSON.parse( fs.readFileSync( packageFile, "utf8" ) ); + if ( ( fs.existsSync || path.existsSync )( packageFile ) ) { + pkgLock = JSON.parse( fs.readFileSync( packageLockFile, "utf8" ) ); + } status( "Current version is " + pkg.version + "; generating release " + releaseVersion ); version = rsemver.exec( pkg.version ); @@ -148,6 +153,7 @@ function updateVersions( next ) { updateSourceVersion( releaseVersion ); updateReadmeVersion( releaseVersion ); updatePackageVersion( releaseVersion ); + updatePackageLockVersion( releaseVersion ); next(); } @@ -212,6 +218,7 @@ async function publishToNPM( next ) { function setNextVersion( next ) { updateSourceVersion( nextVersion ); updatePackageVersion( nextVersion, "main" ); + updatePackageLockVersion( nextVersion ); git( [ "commit", "-a", "--no-verify", "-m", "Updating the source version to " + nextVersion ], next ); } @@ -252,6 +259,15 @@ function updatePackageVersion( ver, blobVer ) { writeJsonSync( packageFile, pkg ); } +function updatePackageLockVersion( ver ) { + status( "Updating " + packageLockFile + " version to " + ver ); + pkgLock.version = ver; + if ( pkgLock?.packages[ "" ].version ) { + pkgLock.packages[ "" ].version = ver; + } + writeJsonSync( packageLockFile, pkgLock ); +} + function updateSourceVersion( ver ) { var stmt = "\njQuery.migrateVersion = \"" + ver + "\";\n"; From d880355f92a6ee788ae46c59c0993519b1791fb1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Go=C5=82e=CC=A8biowski-Owczarek?= Date: Fri, 19 Dec 2025 11:53:12 +0100 Subject: [PATCH 2/2] fixup! Release: Bump version in `package-lock.json` as well during the release --- build/release.js | 42 +++++++++++++++++++----------------------- 1 file changed, 19 insertions(+), 23 deletions(-) diff --git a/build/release.js b/build/release.js index 3e2d3132..194fbe6c 100644 --- a/build/release.js +++ b/build/release.js @@ -18,7 +18,6 @@ var releaseVersion, nextVersion, isBeta, pkg, - pkgLock, prompt = enquirer.prompt, @@ -31,7 +30,6 @@ var releaseVersion, readmeFile = "README.md", packageFile = "package.json", - packageLockFile = "package-lock.json", versionFile = path.join( "src", "version.js" ), releaseDir = "CDN", @@ -101,9 +99,6 @@ function initialize( next ) { die( "No " + packageFile + " in this directory" ); } pkg = JSON.parse( fs.readFileSync( packageFile, "utf8" ) ); - if ( ( fs.existsSync || path.existsSync )( packageFile ) ) { - pkgLock = JSON.parse( fs.readFileSync( packageLockFile, "utf8" ) ); - } status( "Current version is " + pkg.version + "; generating release " + releaseVersion ); version = rsemver.exec( pkg.version ); @@ -152,9 +147,7 @@ function tagReleaseVersion( next ) { function updateVersions( next ) { updateSourceVersion( releaseVersion ); updateReadmeVersion( releaseVersion ); - updatePackageVersion( releaseVersion ); - updatePackageLockVersion( releaseVersion ); - next(); + updatePackageVersion( releaseVersion, undefined, next ); } async function buildRelease( next ) { @@ -217,10 +210,12 @@ async function publishToNPM( next ) { function setNextVersion( next ) { updateSourceVersion( nextVersion ); - updatePackageVersion( nextVersion, "main" ); - updatePackageLockVersion( nextVersion ); - git( [ "commit", "-a", "--no-verify", "-m", "Updating the source version to " + nextVersion ], - next ); + updatePackageVersion( nextVersion, "main", function() { + git( + [ "commit", "-a", "--no-verify", + "-m", "Updating the source version to " + nextVersion ], + next ); + } ); } function pushToRemote( next ) { @@ -251,21 +246,22 @@ function steps() { } )(); } -function updatePackageVersion( ver, blobVer ) { +function updatePackageVersion( ver, blobVer, next ) { status( "Updating " + packageFile + " version to " + ver ); blobVer = blobVer || ver; - pkg.version = ver; pkg.author.url = setBlobVersion( pkg.author.url, blobVer ); writeJsonSync( packageFile, pkg ); -} - -function updatePackageLockVersion( ver ) { - status( "Updating " + packageLockFile + " version to " + ver ); - pkgLock.version = ver; - if ( pkgLock?.packages[ "" ].version ) { - pkgLock.packages[ "" ].version = ver; - } - writeJsonSync( packageLockFile, pkgLock ); + child.execFile( "npm", [ + "version", + ver, + "--no-git-tag-version" + ], function( error, stdout ) { + if ( error ) { + throw error; + } + console.log( stdout ); + next(); + } ); } function updateSourceVersion( ver ) {