When I trade with a faction that I have a commission with the tariff change works fine until I get to maximum reputation with that faction.
I checked through the code and I suspect line 104 in TariffUtil.java:
tariff = tariff < 0f ? -0.3f : tariff;
I think tariff should be set to 0f instead of -0.3f when it is less than 0 at that step so it will correctly set tariffs to 0 in the following steps.
I debugged it locally and it seems to work fine after the change.
When I trade with a faction that I have a commission with the tariff change works fine until I get to maximum reputation with that faction.
I checked through the code and I suspect line 104 in TariffUtil.java:
tariff = tariff < 0f ? -0.3f : tariff;I think tariff should be set to 0f instead of -0.3f when it is less than 0 at that step so it will correctly set tariffs to 0 in the following steps.
I debugged it locally and it seems to work fine after the change.