Fix Stored XSS via malicious SVG uploads#116
Conversation
Adds the `enshrined/svg-sanitize` library to strip malicious `<script>` tags, inline event handlers, and unsafe elements from SVG files. The sanitization process is applied seamlessly in `MediaRepository::validateUploadedFile()` before the file is persisted to storage. Added tests to guarantee the vulnerability remains patched. Co-authored-by: juzaweb <47020363+juzaweb@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixes an issue where users could upload malicious SVG files with embedded scripts, causing Stored XSS vulnerabilities. By sanitizing SVGs during the
validateUploadedFilestep, any uploaded active scripts are effectively stripped.PR created automatically by Jules for task 17819981545323579008 started by @juzaweb