Skip to content

Fix Call to a member function thumbnailUrl() on null khi ko có theme#122

Merged
juzaweb merged 1 commit into
masterfrom
fix/null-theme-thumbnail-error-17052108890914793362
Mar 28, 2026
Merged

Fix Call to a member function thumbnailUrl() on null khi ko có theme#122
juzaweb merged 1 commit into
masterfrom
fix/null-theme-thumbnail-error-17052108890914793362

Conversation

@juzaweb

@juzaweb juzaweb commented Mar 28, 2026

Copy link
Copy Markdown
Owner

Fixes an issue where a fatal error occurs in the theme list page if there are no active themes. Added null checks in both the view and controller to gracefully handle missing Theme::current() instances.


PR created automatically by Jules for task 17052108890914793362 started by @juzaweb

… theme

- Added an `@if ($currentTheme)` check around the theme item component in the `admin.theme.index` Blade view to prevent rendering errors when there's no active theme.
- Updated `ThemeController@loadData` to use the nullsafe operator (`$currentTheme?->name()`) when filtering themes, preventing a related fatal error.

Co-authored-by: juzaweb <47020363+juzaweb@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@juzaweb juzaweb merged commit 19928fb into master Mar 28, 2026
8 checks passed
@juzaweb juzaweb deleted the fix/null-theme-thumbnail-error-17052108890914793362 branch March 28, 2026 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant