Skip to content

Code review #1

@ghsamm

Description

@ghsamm

I appreciate

  • the app functions as expected
  • the design is simple and clean
  • using bootstrap instead of wasting too much time with vanilla CSS

You can improve

  • design
    • use more of the available space, e.g. use bigger font size
  • html
    • import JQuery from CDN
    • fix indentation
  • js
    • use helper functions instead of separate code blocks in one huge function
    • use better variable names, e.g. mainWeather instead of mainWea
    • cover more cases in weather icons
    • select JQuery elements only once and store them in variables

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions