Skip to content

The Wire.endTransmission() should not be used together with Wire.requestFrom(). #1

Description

@Koepel

In some files, for example:

  • D1mini_oop/D1_oop34_BME280/D1_class_BME280.cpp
  • D1mini_oop/D1_oop09_weather1_oled/D1_class_AM2322.h
  • D1mini_oop/D1_oop32_INA226/D1_class_INA226.cpp
  • D1mini_oop/D1_oop12_anemometer1_oled/D1_class_PCF8583.h
  • D1mini_oop/D1_oop04_AM2322/D1_class_AM2322.h
  • D1mini_oop/D1_oop05_AM2322_oled/D1_class_AM2322.h
  • D1mini_oop/D1_oop06_BH1750/D1_class_BH1750.h
  • D1mini_oop/D1_oop18_weatherserver_oled/D1_class_PCF8583.h
  • D1mini_oop/D1_oop31_2xSHT30_oled/D1_class_SHT30.cpp
  • D1mini_oop/D1_oop23_DS1307/D1_oop23_DS1307_setTimeHttp/D1_class_DS1307.cpp

there are a lot Wire.endTransmission() after a Wire.requestFrom(). All those Wire.endTransmission() can be removed. Sometimes there is Wire.beginTransmission() before the Wire.requestFrom(), those can also be removed.
Explanation: Common-mistakes number 2 and 3.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions