Enable build and install on macos#153
Draft
themightyoarfish wants to merge 11 commits into
Draft
Conversation
themightyoarfish
commented
Dec 1, 2024
|
|
||
| set(CMAKE_CXX_STANDARD 17) | ||
| set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_CURRENT_LIST_DIR}/cmake") | ||
| # list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/cmake") |
Contributor
Author
There was a problem hiding this comment.
the problem here is that the vendored cmake module for glm didnt work for me (see issues)
Owner
|
MacOS support sounds so nice. Let me know when the PR gets ready to be reviewed. |
Contributor
Author
|
I dont know if its a retina display issue, but |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the things I had to do to make this work with macos 15.1 with homebrew dependencies.