fix: skill chips now correctly deselect and unhighlight when tapped again#444
Open
ckprojects77 wants to merge 2 commits into
Open
fix: skill chips now correctly deselect and unhighlight when tapped again#444ckprojects77 wants to merge 2 commits into
ckprojects77 wants to merge 2 commits into
Conversation
…gain fixes komalharshita#290 Signed-off-by: chaitanya kumari <chaitanyakumarichalla099@gmail.com>
|
@ckprojects77 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a selected skill chip was tapped again to deselect
it, the tag disappeared from the selected skills list
but the chip itself remained highlighted in blue. This
happened because a duplicate nested fetch block in
script.js was causing a JavaScript syntax error that
crashed the entire script before event listeners could
register. With the broken code removed, the chip
selection state now stays in sync with the selected
tags clicking a chip highlights it and adds the tag,
clicking it again removes both the highlight and the tag.
Related Issue
Closes #290
Type of Change
What Was Changed
|
static/script.js| Removed duplicate nested fetch block that was causing a syntax error and preventing chip deselection from working ||
templates/index.html| Fixed broken input tag that was rendering raw aria attributes as visible text on the page |How to Test This PR
git checkout fix/skill-chip-deselectionpip install -r requirements.txtpython app.pyTest Results
Frontend only fix no backend tests affected.
Screenshots
Self-Review Checklist
Notes for Reviewer
This fix also resolves the broken skills input tag in
templates/index.html where raw aria attributes were
rendering as visible text on the page due to a
prematurely closed input element.