Skip to content

fix: skill chips now correctly deselect and unhighlight when tapped again#444

Open
ckprojects77 wants to merge 2 commits into
komalharshita:mainfrom
ckprojects77:fix/skill-chip-deselection
Open

fix: skill chips now correctly deselect and unhighlight when tapped again#444
ckprojects77 wants to merge 2 commits into
komalharshita:mainfrom
ckprojects77:fix/skill-chip-deselection

Conversation

@ckprojects77
Copy link
Copy Markdown

Summary

When a selected skill chip was tapped again to deselect
it, the tag disappeared from the selected skills list
but the chip itself remained highlighted in blue. This
happened because a duplicate nested fetch block in
script.js was causing a JavaScript syntax error that
crashed the entire script before event listeners could
register. With the broken code removed, the chip
selection state now stays in sync with the selected
tags clicking a chip highlights it and adds the tag,
clicking it again removes both the highlight and the tag.

Related Issue

Closes #290

Type of Change

  • Bug fix — resolves a broken behaviour

What Was Changed

| static/script.js | Removed duplicate nested fetch block that was causing a syntax error and preventing chip deselection from working |
| templates/index.html | Fixed broken input tag that was rendering raw aria attributes as visible text on the page |

How to Test This PR

  1. Clone this branch: git checkout fix/skill-chip-deselection
  2. Install dependencies: pip install -r requirements.txt
  3. Run the app: python app.py
  4. Open http://127.0.0.1:5000
  5. Scroll to Your Skills section
  6. Click any skill chip like React — it should highlight and appear as a tag
  7. Click the same chip again — it should unhighlight and the tag should disappear
  8. Both the chip and tag should stay in sync at all times

Test Results

Frontend only fix no backend tests affected.

Screenshots

Screenshot 2026-05-22 121138

Self-Review Checklist

  • I have read CONTRIBUTING.md and followed all guidelines
  • My branch name follows the convention: fix/skill-chip-deselection
  • I have not introduced any print() or console.log() debug statements
  • I have not modified files outside the scope of the linked issue
  • If I changed the UI, I tested it at 375px and 1280px

Notes for Reviewer

This fix also resolves the broken skills input tag in
templates/index.html where raw aria attributes were
rendering as visible text on the page due to a
prematurely closed input element.

…gain fixes komalharshita#290

Signed-off-by: chaitanya kumari <chaitanyakumarichalla099@gmail.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

@ckprojects77 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Selected skill chips remain highlighted after skill is removed by tapping on it

1 participant