ensure finalizers are set on all catalog apps + remove stale apps #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

johndietz merged 2 commits into main from finalizers

Sep 10, 2025

-Original file line number
+Diff line change
@@ Expand Up / @@ -8,6 +8,8 @@ metadata: @@
         argocd.argoproj.io/sync-wave: '20'
         kubefirst.konstruct.io/application-name: cluster-autoscaler-aws
         kubefirst.konstruct.io/source: catalog-templates
+      finalizers:
+        - resources-finalizer.argocd.argoproj.io
     spec:
       project: <PROJECT>
       source:
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -4,6 +4,11 @@ kind: Application @@
     metadata:
       name: <CLUSTER_NAME>-grapple-solution-framework
       namespace: argocd
+      annotations:
+        kubefirst.konstruct.io/application-name: grapple-solution-framework
+        kubefirst.konstruct.io/source: catalog-templates
+      finalizers:
+        - resources-finalizer.argocd.argoproj.io
     spec:
       project: <PROJECT>
       source:
@@ Expand Down @@

index.yaml

-Original file line number
+Diff line change
@@ Expand Up / @@ -234,30 +234,6 @@ apps: @@
         description: "The open source Firebase alternative."
         category: Database
-      - name: testkube
-        displayName: Testkube
-        website: "https://github.com/kubeshop/testkube"
-        imageUrl: "https://raw.githubusercontent.com/konstructio/gitops-catalog/main/logos/testkube.svg"
-        description: "Testkube is a Kubernetes-native testing framework that allows you to automate the executions of your existing testing tools inside your Kubernetes cluster."
-        category: Testing
-        secretKeys:
-          - name: API_KEY
-            label: Testkube API Key
-            env: TESTKUBE_APP_KEY
-          - name: ORG_ID
-            label: Testkube Org ID
-            env: TESTKUBE_ORG_ID
-          - name: ENV_ID
-            label: Testkube Environment ID
-            env: TESTKUBE_ENV_ID
-      - name: tracetest
-        displayName: Tracetest
-        website: "https://github.com/kubeshop/tracetest"
-        imageUrl: "https://raw.githubusercontent.com/konstructio/gitops-catalog/main/logos/tracetest.svg"
-        description: "Tracetest uses your existing OpenTelemetry traces to power trace-based testing with assertions against your trace data at every point of the request transaction."
-        category: Testing
       - name: typesense
         displayName: TypeSense
         website: "https://github.com/typesense/typesense"
@@ Expand Down @@

logos/testkube.svg

This file was deleted.

logos/tracetest.svg

This file was deleted.

testkube/components/testkube/application.yaml

This file was deleted.

testkube/components/testkube/external-secret.yaml

This file was deleted.

testkube/testkube.yaml

This file was deleted.

tracetest/components/tracetest/application.yaml

This file was deleted.

tracetest/tracetest.yaml

This file was deleted.

Provide feedback