Skip to content

bash jobs unnecessary --params requirement #226

@dapineyro

Description

@dapineyro

The following command cloudos bash job --workflow-name ubuntu --command "echo 'a' > txt.txt" --last fails with the following error:

ValueError: No --job-config, --nextflow_profile, --parameter or --example_parameters were specified,  please use at least one of these options.

There are two issues here:

  1. The following code snippet is not correctly capturing the bash jobs (aka docker), as it always triggers the first if:

if (
nextflow_profile is None and
job_config is None and
len(parameter) == 0 and
len(example_parameters) == 0
):
raise ValueError('No --job-config, --nextflow_profile, --parameter or ' +
'--example_parameters were specified,' +
' please use at least one of these options.')
if workflow_type == 'wdl' and job_config is None and len(parameter) == 0:
raise ValueError('No --job-config or --parameter were provided. At least one of ' +
'these are required for WDL workflows.')
if workflow_type == 'docker' and len(parameter) == 0:
raise ValueError('No --parameter were provided. At least one of ' +
'these are required for bash workflows.')

  1. Bash jobs can run without params in the platform, so the following check is not necessary:

if workflow_type == 'docker' and len(parameter) == 0:
raise ValueError('No --parameter were provided. At least one of ' +
'these are required for bash workflows.')

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions