Skip to content

Commit 385f58c

Browse files
committed
base_image: ensure base image permissions are set
Permissions should be set regardless of if we executed the copy task or not. Workflow: TASK: Show the custom virt-builder database [localhost] Custom virt-builder source: /etc/virt-builder/repos.d/ kdevops-custom-images-debian-13-generic-arm64-daily.conf Custom virt-builder index: /var/lib/libvirt/images/kdevops/guestfs/custom_images/ debian-13-generic-arm64-daily/index Custom virt-builder image: /var/lib/libvirt/images/kdevops/guestfs/custom_images/ debian-13-generic-arm64-daily/debian-13-generic-arm64-daily.raw TASK: Generating the index for debian-13-generic-arm64-daily [localhost] ⠀⠀✓ [localhost] TASK: Copy custom image to base image location (with automatic reflink optimization) [localhost] ⠀⠀⊘ [localhost] TASK: Set proper permissions on base image [localhost] ⠀⠀⊘ [localhost] TASK: Create the base OS image [localhost] ⠀⠀⊘ [localhost] ... Fixes error: TASK: Duplicate the root disk image for each target node [dgc-testing-block,dgc-testing-nvme] ⠀⠀FAILED: [dgc-testing-block] => non-zero return code STDERR: cp: cannot open '/var/lib/libvirt/images/kdevops/guestfs/custom_images/ debian-13-generic-arm64-daily/debian-13-generic-arm64-daily.raw' for reading: Permission denied [ERROR]: Task failed: Module failed: non-zero return code Origin: /home/dagomez.linux/src/kdevops/playbooks/roles/guestfs/tasks/bringup/ main.yml:53:7 51 delegate_to: localhost 52 53 - name: Duplicate the root disk image for each target node ^ column 7 Fixes: f9ef79c ("base_image: optimize VM image copying with reflinks and fix same-file handling") Link: https://lore.kernel.org/r/20250929-locales-all-removal-v1-2-4177411d3e44@samsung.com Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
1 parent 057f3a1 commit 385f58c

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

playbooks/roles/base_image/tasks/custom-image.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,4 +355,3 @@
355355
mode: "u=rw,g=r,o=r"
356356
when:
357357
- custom_image_stat.stat.exists or custom_image_download is changed
358-
- custom_image != base_image_pathname

0 commit comments

Comments
 (0)