Skip to content

Commit 98c595e

Browse files
cleanup comments
1 parent 92a4347 commit 98c595e

3 files changed

Lines changed: 1 addition & 39 deletions

File tree

bridge/README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ bridge.unregisterRpcMethod("greet");
5757
// Controller side: send commands to the publisher
5858
controller_bridge.requestRemoteTrackMute("robot-1", "mic"); // mute audio track "mic"
5959
controller_bridge.requestRemoteTrackUnmute("robot-1", "mic"); // unmute it
60-
controller_bridge.requestTrackRelease("robot-1", "cam"); // unpublish video track "cam"
6160

6261
// 7. Cleanup is automatic (RAII), or explicit:
6362
mic.reset(); // unpublishes the audio track
@@ -158,7 +157,6 @@ bridge.connect(url, token, options);
158157
| `unregisterRpcMethod(method_name)` | Unregister a previously registered RPC handler. |
159158
| `requestRemoteTrackMute(identity, track_name)` | Ask a remote participant to mute a track by name. Throws `livekit::RpcError` on failure. |
160159
| `requestRemoteTrackUnmute(identity, track_name)` | Ask a remote participant to unmute a track by name. Throws `livekit::RpcError` on failure. |
161-
| `requestTrackRelease(identity, track_name)` | Ask a remote participant to release (unpublish) a track by name. Throws `livekit::RpcError` on failure. |
162160

163161
### `BridgeAudioTrack`
164162

bridge/include/livekit_bridge/livekit_bridge.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -402,7 +402,7 @@ class LiveKitBridge {
402402
const std::shared_ptr<livekit::Track> &track,
403403
VideoFrameCallback cb);
404404

405-
/// Execute a track action (mute/unmute/release) by track name.
405+
/// Execute a track action (mute/unmute) by track name.
406406
/// Used as the TrackActionFn callback for RpcController.
407407
/// Throws livekit::RpcError if the track is not found.
408408
/// @pre Caller does NOT hold mutex_ (acquires it internally).

bridge/tests/integration/test_bridge_rpc_roundtrip.cpp

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -234,42 +234,6 @@ TEST_F(BridgeRemoteTrackControlTest, RemoteMuteVideoTrack) {
234234
video_track->release();
235235
}
236236

237-
// ---------------------------------------------------------------------------
238-
// Test 6: Remote release of a data track.
239-
//
240-
// Data tracks have no mute/unmute, only release.
241-
// ---------------------------------------------------------------------------
242-
TEST_F(BridgeRemoteTrackControlTest, RemoteReleaseDataTrack) {
243-
skipIfNotConfigured();
244-
245-
std::cout << "\n=== Bridge Remote Release Data Track Test ===" << std::endl;
246-
247-
LiveKitBridge publisher;
248-
LiveKitBridge controller;
249-
250-
ASSERT_TRUE(connectPair(controller, publisher));
251-
252-
const std::string publisher_identity = "rpc-receiver";
253-
254-
auto data_track = publisher.createDataTrack("sensor-data");
255-
ASSERT_NE(data_track, nullptr);
256-
ASSERT_TRUE(data_track->isPublished());
257-
258-
std::this_thread::sleep_for(2s);
259-
260-
std::cout << "Requesting release on data track..." << std::endl;
261-
EXPECT_NO_THROW(
262-
controller.requestTrackRelease(publisher_identity, "sensor-data"));
263-
264-
std::this_thread::sleep_for(500ms);
265-
266-
EXPECT_TRUE(data_track->isReleased());
267-
268-
std::vector<std::uint8_t> payload{0x01, 0x02};
269-
bool pushed = data_track->pushFrame(payload);
270-
EXPECT_FALSE(pushed) << "pushFrame should fail after remote release";
271-
}
272-
273237
// ---------------------------------------------------------------------------
274238
// Test 7: Remote mute on a nonexistent track returns an error.
275239
// ---------------------------------------------------------------------------

0 commit comments

Comments
 (0)