Skip to content

Commit bda9732

Browse files
committed
skip installing dev packages to avoid dependency issues
1 parent f7cdac0 commit bda9732

2 files changed

Lines changed: 3 additions & 9 deletions

File tree

.github/workflows/aws-proxy.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,8 @@ jobs:
4848
docker pull localstack/localstack-pro &
4949
docker pull public.ecr.aws/lambda/python:3.8 &
5050
51-
# install latest CLI packages (dev releases)
52-
pip install --upgrade --pre localstack localstack-ext
53-
54-
# TODO remove
55-
mkdir ~/.localstack; echo '{"token":"test"}' > ~/.localstack/auth.json
51+
# install latest CLI packages
52+
pip install --upgrade localstack localstack-ext
5653
5754
# install dependencies
5855
sudo apt-get update
@@ -63,7 +60,6 @@ jobs:
6360
(
6461
make install
6562
. .venv/bin/activate
66-
pip install --upgrade --pre localstack localstack-ext
6763
make build
6864
make enable
6965
)

aws-proxy/Makefile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ FRONTEND_FOLDER = aws_proxy/frontend
88
COREPACK_EXISTS := $(shell command -v corepack)
99
YARN_EXISTS := $(shell command -v yarn)
1010

11-
venv: $(VENV_ACTIVATE)
12-
1311
usage: ## Show this help
1412
@grep -Fh "##" $(MAKEFILE_LIST) | grep -Fv fgrep | sed -e 's/:.*##\s*/##/g' | awk -F'##' '{ printf "%-25s %s\n", $$1, $$2 }'
1513

@@ -52,7 +50,7 @@ check-frontend-deps:
5250
npm install -g corepack; \
5351
fi
5452

55-
install-frontend: venv check-frontend-deps ## Install dependencies of the frontend
53+
install-frontend: check-frontend-deps ## Install dependencies of the frontend
5654
cd $(FRONTEND_FOLDER) && yarn install
5755

5856
build-frontend: # Build the React app

0 commit comments

Comments
 (0)