Skip to content

fix: publish with npm trusted publishing#28

Merged
yltw27 merged 1 commit into
mainfrom
fix/github-action-npm-publish
May 21, 2026
Merged

fix: publish with npm trusted publishing#28
yltw27 merged 1 commit into
mainfrom
fix/github-action-npm-publish

Conversation

@yltw27
Copy link
Copy Markdown
Collaborator

@yltw27 yltw27 commented May 20, 2026

Summary

Fixes the main release workflow so public package publishes use npm trusted publishing instead of requiring an npm token.

This also recovers the current state where @loveholidays/eval-kit@1.2.0 was versioned on main but not published to npm after the failed release job.

Changes

  • Configure npm registry metadata in actions/setup-node.
  • Detect whether the current package version is already published to npm.
  • Run publish when changesets exist or the current version is unpublished.
  • Publish with npm@11 and OIDC-backed trusted publishing, without NPM_TOKEN.

Verification

  • pnpm lint
  • pnpm typecheck
  • pnpm test
  • pnpm build
  • git diff --check
  • YAML parse check
  • npm publish --dry-run --access public

CodeScene was waived for this PR by request; local CodeScene could not run because CS_ACCESS_TOKEN is not configured.

Use npm trusted publishing for the main release workflow and recover already-versioned releases when the package version has not reached npm.

Co-Authored-By: Codex (GPT-5) <noreply@openai.com>
@yltw27 yltw27 marked this pull request as ready for review May 21, 2026 08:51
@yltw27 yltw27 requested a review from a team as a code owner May 21, 2026 08:51
@yltw27 yltw27 requested review from djslimbo, horlaarsco and matt-koevort and removed request for a team May 21, 2026 08:51
@yltw27 yltw27 merged commit bc58618 into main May 21, 2026
2 checks passed
@yltw27 yltw27 deleted the fix/github-action-npm-publish branch May 21, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant