Noticeable Drop in Performance Using 3D Textures

[jake0rich]

Hello,

I would like to highlight something interesting I have discovered while checking for functionality on my modpack.

From version 1.1.11 to 1.1.12 there was a significant drop in performance around 3D textures. Shown in the images are v1.1.11 with and without 3D textures and v1.1.13 with and without 3D textures. (No that's not a typo just the version I tested on; it seems to be consistent with newer versions). As shown, I do get performance back just from removing the 3D textures, but the performance was there prior to that update.

v1.1.11 2D

v1.1.11 3D

v1.1.13 2D

v1.1.13 3D

I think the memory usage is just a coincidence of when I took the screenshot and not indicative of the performance, but I may be wrong. I have not looked into that.

Looking at the change logs swinging chains were added. This would make sense as the structure I am in has a significant number of chains. However, upon disabling the feature with the built-in config in modmenu, the issue persists. Even disabling the entire mod does not improve performance but a few fps. There may be opportunity to improve performance around the disabling of features here, but I have not actually looked at any code, so take that sparingly.

For reference and repeatability, I am using Dungeons and Taverns: Stronghold Overhaul as this structure, as mentioned before, has a significant number of chains making it ideal for testing. Another place I have found to be a decent testing ground is mineshafts. In recent updates, sections of the mineshafts in large caves are supported by chains.

[maDU59]

Hi,
thanks a lot for opening this issue, it's really complete and provide a lot of useful informations!
I can do it myself when I have some time but just incase it's an issue I can't reproduce, would you mind putting spark in your modpack and run /sparkc profiler start, wait ~10 seconds, run /sparkc profiler stop and send me the link it gives you with all the profiler data, that would help me a lot to find the issue.

I'll do my best to fix this issue in the shortest time possible

[jake0rich]

Here is the spark query I ran last night when I was trouble shooting with claude.

https://spark.lucko.me/Nf69hARty4

[maDU59]

I am not sure if the bug got fixed since then or if I'm using the wrong 3D chains pack or if I just can't reproduce this issue but it works fine on my end. Are ou sure the spark report is from a run with 3D chains on? The mod doesn't to be the most performance-heavy.

Anyway, I don't know how to fix your issue (or if it already is), but what I did is improving the toggles.
Before, when disabled or linked to the ground, the chains were still rendered by the mod, but without moving. That was a bit tricky but it was a lot easier because even when the chain animations were disabled, they could still be animated because of a lantern. This is not the case anymore.
This means that if this mod was the cause of the FPS drop, it won't be in this case anymore, because the chains are linked to the chandeliers which means they are not swinging which means with the latest update they won't be handled by the mod anymore.

Here's the update: https://modrinth.com/mod/fwa/version/1.1.17-beta

[jake0rich]

Thank you for the attention to this and for getting a response so quickly.

As an aside I am using Vanilla Tweaks 3D Chains. Apologies, I should has stated that in my original post as well.

As for the fix, I did get slight improvement gains but not nearly as much as downgrading to v1.1.11. I am happy with a ~200% increase in frames though. Thank you.

To cover all bases about what I did prior to opening this issue, I performed a binary search on the 100 mods that are in the modpack and it lead me to this one being a key driver for the frame drop problem. Additionally, I am not seeing any performance hits outside of the game, so I do not believe this is a system issue.

One note is that I am also using the latest version of complimentary shaders opposed to the vanilla shaders. (Keeping it consistent amongst my tests as they are all run with shaders). Obviously, when I disable them, the frames sky rocket, and while I'll never be able to tell the difference (so this is more of an observation), on v1.1.11 I am receiving 800 fps and on v1.1.17 I am receiving 400 fps, a significant drop. I am unsure if you have done any testing with shaders or shader performance but this could be note worthy.

Finally, I believe it may just be the shear number of chains in the structure. In the image you sent it is hard to tell how many there are but I imagine there's more than ~450ish. I have not count the number of chains in this structure particularly but it is either at that or a bit more. I'm curious to see if you get similar results in the updated structure from DnT though.

Complementary Shaders v1.1.17

Complementary Shaders v1.1.11

Vanilla Shaders v1.1.17

Vanilla Shaders v1.1.11

Similar Set Up as You

However the chains will not wave nor are there config options in the .json file or the modmenu for chains.

I am unaware of what else was changed from v1.1.11 to v1.1.12, so I was hoping you may be able to provide some insist into that. As from my last image it may not even be the chains at all, but something weird certainly is happening. Perhaps it is something around the compatibility? Other than that I don't know.

[maDU59]

On your last screenshot, I believe the reasons your chains do not move is you're on 1.1.11.

Vanilla Tweaks' 3D chains seems top be the same as the one I was using so idk, I'll run more tests, with shaders this time and I'll try to find a better fix, I'll tell you when I find something.

As for the change shappening on 1.1.12, they are all linked to swinging chains/lanterns except a small change for the composter animation but it has nothing to do with this issue

[maDU59]

I managed to reproduce it, I believe it only happens when using Iris/Sodium or it does not happen on 21.6, now that I managed to reproduce it I'll try to optimise it

In the reproduction, the mod takes more time than Sodium and Iris just to render the chains:
https://spark.lucko.me/yVkTOgiV3X

However, with chains linked to the ground:

3D textures:

2D textures:

So there is still some improvements as, previously, the performance hit would've been the same as not linked to the ground

[maDU59]

After searching for a solution, I came to the conclusion that I can not do much about the 3D textures slowing down the rendering.
However, what I can do is try as much as possible not to render them, so I added frustum culling to the animations (they're not gonna be rendered if they're not in the field of view).

https://modrinth.com/mod/fwa/version/1.1.17

This should improve your FPS in the structure as it's big and I assume half of the chains are behind you. I also improved a bit more the chain/lantern logic so now chains are only rendered by the mod when needed. You should get +80% of the performance of 1.1.11.

Also, disabling the mod or the chain (and lantern if needed) animations should now work as you'd expect it and fix any lag related to them.
I really hope it'll work better on your end, if you need any more help or have any issue with the newest version, don't hesitate to tell me.