Skip to content

added contact to navbar #961

Open
Mulesneha wants to merge 2 commits into
magic-peach:mainfrom
Mulesneha:main
Open

added contact to navbar #961
Mulesneha wants to merge 2 commits into
magic-peach:mainfrom
Mulesneha:main

Conversation

@Mulesneha
Copy link
Copy Markdown

@Mulesneha Mulesneha commented May 22, 2026

Description

Added a Contact navigation feature to improve website accessibility and navigation experience.

Changes Made

  • Added id="contact" to the footer section
  • Added Contact navigation link for smooth scrolling
  • Improved user navigation to quickly access the footer/contact section
  • Maintained responsive and accessible UI behavior

Related Issue

Closes #956

Type of Contribution

New feature
Documentation update

  • GSSoC contribution

Participant Info

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes locally
  • bun run lint passes successfully
  • bunx tsc --noEmit passes successfully
  • Added accessible navigation elements
  • No unnecessary console logs remain
  • This PR is linked to a valid issue
  • Screen recording attached

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

@Mulesneha is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

⚠️ PR Format Issues — @Mulesneha

Please fix the following before your PR can be reviewed:

  • ⚠️ Use a conventional PR title. Examples:
    • feat: add dark mode support
    • fix: resolve aria label missing on slider
    • docs: add deployment guide to README

Push new commits after fixing — this comment will update automatically.

📖 CONTRIBUTING.md

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @Mulesneha!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added level:intermediate Intermediate level - 35 pts type:design UI/UX design type:docs Documentation type:feature New feature gssoc'26 GirlScript Summer of Code 2026 labels May 22, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented May 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
reframe Error Error May 23, 2026 11:02am

@magic-peach magic-peach added gssoc:approved Approved for GSSoC'26 quality:clean Well-implemented, clean code labels May 23, 2026
@magic-peach
Copy link
Copy Markdown
Owner

@Mulesneha the deployment failed please fix and also do star the repo

@magic-peach
Copy link
Copy Markdown
Owner

Hey @Mulesneha! CI is failing on this PR — here's what needs to be fixed.

Failing checks: typecheck, build (and Vercel downstream)

Root cause: src/app/layout.tsx has a duplicate export default. Your PR added a new RootLayout function at the top of the file, but the original RootLayout export already exists lower in the file. This causes:

src/app/layout.tsx(12,25): error TS2323: Cannot redeclare exported variable 'default'.
src/app/layout.tsx(12,25): error TS2393: Duplicate function implementation.
src/app/layout.tsx(12,38): error TS7031: Binding element 'children' implicitly has an 'any' type.

The diff shows you inserted a new export default function RootLayout({ children }) block early in the file, while the existing full implementation (with metadata, providers, ThemeToggle, etc.) remains further down.

How to fix:

  1. Open src/app/layout.tsx.
  2. Remove the new minimal RootLayout block you added near the top (lines ~12–22 approximately).
  3. Instead, add your <Navbar /> component inside the existing RootLayout function body, where it fits in the JSX (before {children}).
  4. Also remove the duplicate import "./globals.css" — it's already imported.
  5. Make sure children has the correct type: React.ReactNode.
  6. Run bunx tsc --noEmit and bun run lint locally to verify.

The existing RootLayout with all the providers and theme logic is the one to keep — just add <Navbar /> inside it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved Approved for GSSoC'26 gssoc'26 GirlScript Summer of Code 2026 level:intermediate Intermediate level - 35 pts quality:clean Well-implemented, clean code type:design UI/UX design type:docs Documentation type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] :add contact option in navigation bar

2 participants